Repository navigation
Publish ClusterTopologyChangedEvent after applying the new topology #2860 - #3791
Merged
a-TODO-rov merged 2 commits intoJun 17, 2026
Merged
Conversation
a-TODO-rov
approved these changes
Jun 17, 2026
a-TODO-rov
left a comment
Collaborator
There was a problem hiding this comment.
Looks good
Thanks @shun-lee
a-TODO-rov
added a commit
that referenced
this pull request
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2860
Problem
In
RedisClusterClient.refreshPartitionsAsync()theClusterTopologyChangedEventispublished before the new topology is applied:
Since
getPartitions()returns the samePartitionsinstance thatreload()mutates inplace, an event listener that inspects the topology while handling the event can observe
stale partitions.
Concrete impact: an application that re-subscribes to master nodes on
ClusterTopologyChangedEvent(usingconnection.getPartitions()/ node selection) can,right after a failover, select the demoted old masters (now replicas) instead of the
newly promoted masters, and stay subscribed to replicas until the next topology change.
Fix
Capture the
before/aftersnapshots before applying the topology (so the event payloadstays correct), apply the topology via
reload()+updatePartitionsInConnections(), andpublish the event only afterwards. Listeners now observe the up-to-date partitions.