Repository navigation
Upgrade GitHub Actions versions (#3773) - part 2 - #3784
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The https://github.com/redis/lettuce/actions/workflows/benchmarks.yml seems to be failing since the 4th of June
Quite likely this is related to the #3773 bump of the dependencies.
Seems that the
actions/checkout@v6moved its credential persistence out of http.https://github.com/.extraheader and this causes other actions (in this cases4u/setup-maven-action@v1.19.0, which internally uses the v5 version of the checkout action) to fail.Since we need neither the
actions/checkout@v6(nor theactions/setup-java@v5for that matter) removing them both should do the trick.Make sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.Note
Low Risk
CI-only change to one workflow; no application or library code is affected.
Overview
Fixes the failing Benchmarks workflow by dropping the separate
actions/checkout@v6andactions/setup-java@v5steps and relying only ons4u/setup-maven-action@v1.19.0for checkout, Java 8, and Maven setup.The workflow now passes
java-distribution: temurininto that action so Temurin is still used. This avoids a conflict where checkout v6’s credential handling breaks the action’s internal checkout (often cited as the cause of failures since the earlier Actions version bump).Reviewed by Cursor Bugbot for commit e6a99d4. Bugbot is set up for automated code reviews on this repo. Configure here.