Skip to content

Upgrade GitHub Actions versions (#3773) - part 2 - #3784

Merged
a-TODO-rov merged 1 commit into
redis:mainfrom
tishun:topic/tishun/issue-3773-part2
Jun 16, 2026
Merged

a-TODO-rov merged 1 commit into
redis:mainfrom
tishun:topic/tishun/issue-3773-part2

Conversation

@tishun

@tishun tishun commented Jun 15, 2026 •

Copy link
Copy Markdown
Collaborator

The https://github.com/redis/lettuce/actions/workflows/benchmarks.yml seems to be failing since the 4th of June
Quite likely this is related to the #3773 bump of the dependencies.

Seems that the actions/checkout@v6 moved its credential persistence out of http.https://github.com/.extraheader and this causes other actions (in this case s4u/setup-maven-action@v1.19.0, which internally uses the v5 version of the checkout action) to fail.

Since we need neither the actions/checkout@v6 (nor the actions/setup-java@v5 for that matter) removing them both should do the trick.

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Note

Low Risk
CI-only change to one workflow; no application or library code is affected.

Overview
Fixes the failing Benchmarks workflow by dropping the separate actions/checkout@v6 and actions/setup-java@v5 steps and relying only on s4u/setup-maven-action@v1.19.0 for checkout, Java 8, and Maven setup.

The workflow now passes java-distribution: temurin into that action so Temurin is still used. This avoids a conflict where checkout v6’s credential handling breaks the action’s internal checkout (often cited as the cause of failures since the earlier Actions version bump).

Reviewed by Cursor Bugbot for commit e6a99d4. Bugbot is set up for automated code reviews on this repo. Configure here.

@tishun
tishun requested review from a-TODO-rov and uglide June 15, 2026 07:16
@a-TODO-rov
a-TODO-rov merged commit 1c21ed5 into redis:main Jun 16, 2026
14 checks passed
@tishun
tishun deleted the topic/tishun/issue-3773-part2 branch June 23, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址