Repository navigation
feature: Add Bloom Filter (BF.*) support to Lettuce #3759 - #3760
Conversation
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
…f a map. Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
…oomFilterCommandBuilder logic. Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
# Conflicts: # src/main/java/io/lettuce/core/AbstractRedisAsyncCommands.java # src/main/java/io/lettuce/core/AbstractRedisReactiveCommands.java # src/main/java/io/lettuce/core/api/async/RedisAsyncCommands.java # src/main/java/io/lettuce/core/api/reactive/RedisReactiveCommands.java # src/main/java/io/lettuce/core/api/sync/RedisCommands.java # src/main/java/io/lettuce/core/cluster/api/async/RedisClusterAsyncCommands.java # src/main/java/io/lettuce/core/cluster/api/reactive/RedisClusterReactiveCommands.java # src/main/java/io/lettuce/core/cluster/api/sync/RedisClusterCommands.java # src/main/java/io/lettuce/core/protocol/CommandKeyword.java # src/main/kotlin/io/lettuce/core/api/coroutines/RedisCoroutinesCommandsImpl.kt # src/test/java/io/lettuce/apigenerator/Constants.java
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
a-TODO-rov
left a comment
There was a problem hiding this comment.
General comment:
Some new files lack license header, the ones that do are inconsistent between each other. Please consult with @uglide what the latest state of the license header should look like, because i don't know myself.
Some inline comments:
@Dgramada @a-TODO-rov something like: // Copyright (c) 2026-Present, Redis Ltd. All rights reserved.
// SPDX-License-Identifier: MITis more than enough |
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit e6644d0. Configure here.

Add Bloom Filter support to Redis. First commit is a draft of the sync command API.
Make sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.Note
Medium Risk
Large additive API surface with custom RESP parsing and error-tolerant outputs for insert/madd; cluster read-only command set grows, but changes mirror existing module patterns and are covered by unit and integration tests.
Overview
Adds Redis Bloom Filter (
BF.*) client support across sync, async, reactive, Kotlin coroutines, and cluster node-selection APIs, following the same module pattern as other Redis Stack features.Command surface:
bfAdd,bfCard,bfExists,bfInfo,bfInsert(withBfInsertArgs),bfMAdd,bfMExists,bfReserve(withBfReserveArgs),bfScanDump, andbfLoadChunk. Protocol wiring addsCommandTypeentries,CommandKeywordoptions (CAPACITY,ITEMS,NONSCALING, etc.), and marksBF_CARD,BF_EXISTS,BF_INFO, andBF_MEXISTSas read-only for cluster routing.Implementation:
RedisBloomFilterCommandBuilderencodes commands;BfInfoValue/BfScanDumpValueuse dedicated parsers.BF.INSERTandBF.MADDuse new error-tolerant list outputs so per-item failures map tonull(async/sync) orValue.empty()(reactive) when a non-scaling filter is full. Reactive insert/madd use separatebfInsertValues/bfMAddValuesbuilders forFlux<Value<Boolean>>.Integration:
AbstractRedisAsyncCommandsandAbstractRedisReactiveCommandsimplement the new interfaces; aggregateRedis*Commandstypes extendRedisBloomFilter*Commands. API generator templateRedisBloomFilterCommandsis registered in test constants. Unit tests cover RESP encoding; integration tests cover standalone, RESP2, reactive, and cluster.Reviewed by Cursor Bugbot for commit 60b5695. Bugbot is set up for automated code reviews on this repo. Configure here.