Skip to content

Introduce INCREX command - #3746

Merged
a-TODO-rov merged 4 commits into
mainfrom
increx
May 22, 2026
Merged

a-TODO-rov merged 4 commits into
mainfrom
increx

Conversation

@a-TODO-rov

@a-TODO-rov a-TODO-rov commented May 14, 2026 •

Copy link
Copy Markdown
Collaborator

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Note

Medium Risk
Adds a new Redis command (INCREX) across sync/async/reactive/coroutines APIs with new argument builders and custom response parsing, which could affect command encoding/decoding and compatibility with older servers.

Overview
Adds first-class support for the Redis INCREX command across the Lettuce string command APIs (sync/async/reactive, cluster node selection, and Kotlin coroutines), including overloads for default increment and typed BYINT/BYFLOAT variants.

Introduces IncrexArgs/IncrexFloatArgs (with shared BaseIncrexArgs) to encode bounds (LBOUND/UBOUND), SATURATE, and expiration options (EX/PX/EXAT/PXAT/PERSIST/ENX), plus a new IncrexValue<T> result type parsed via IncrexLongOutput/IncrexDoubleOutput. Updates protocol enums (CommandType.INCREX, new CommandKeywords) and adds unit/integration coverage, including RESP2 integration tests.

Reviewed by Cursor Bugbot for commit c1eca2c. Bugbot is set up for automated code reviews on this repo. Configure here.

@jit-ci

jit-ci Bot commented May 14, 2026 •

Copy link
Copy Markdown

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@a-TODO-rov
a-TODO-rov marked this pull request as ready for review May 15, 2026 07:27
@a-TODO-rov a-TODO-rov linked an issue May 15, 2026 that may be closed by this pull request

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8c5163a. Configure here.

@atakavci atakavci left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall its good. just one comment with IncrexArgs.

@atakavci atakavci left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-TODO-rov
a-TODO-rov merged commit 312ecc7 into main May 22, 2026
20 of 21 checks passed
@a-TODO-rov
a-TODO-rov deleted the increx branch May 22, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support INCREX command (Redis 8.8)

2 participants

⌂ 换网址