Skip to content

Fix imports in benchmarks client - #3737

Merged
a-TODO-rov merged 3 commits into
redis:mainfrom
atakavci:ali/fixEmptyRedisClusterClient
Apr 29, 2026
Merged

a-TODO-rov merged 3 commits into
redis:mainfrom
atakavci:ali/fixEmptyRedisClusterClient

Conversation

@atakavci

@atakavci atakavci commented Apr 29, 2026 •

Copy link
Copy Markdown
Collaborator

Benchmarks fail to compile due to issue i introduced in 3735


Note

Low Risk
Test/benchmark-only change limited to imports/signature alignment; no production logic is modified.

Overview
Fixes JMH benchmark compilation by updating EmptyRedisClusterClient to import Reactor Mono (matching the connectToNode override signature) and removing an unused Supplier import.

Reviewed by Cursor Bugbot for commit 7fee3a2. Bugbot is set up for automated code reviews on this repo. Configure here.

atakavci and others added 2 commits April 29, 2026 09:48
Co-authored-by: Copilot <copilot@github.com>
@atakavci
atakavci requested review from a-TODO-rov and Copilot April 29, 2026 13:10
@atakavci atakavci self-assigned this Apr 29, 2026
@atakavci atakavci added the type: techdebt Things that can be improved or refactored label Apr 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes JMH benchmark compilation by correcting imports in the benchmark-only EmptyRedisClusterClient, aligning it with the updated connectToNode signature introduced during the async connect refactor (PR #3735).

Changes:

  • Remove the unused java.util.function.Supplier import.
  • Add the missing reactor.core.publisher.Mono import required by the connectToNode(...) parameter type.
  • Minor formatting (trailing blank line) cleanup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@a-TODO-rov
a-TODO-rov merged commit 9638cab into redis:main Apr 29, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: techdebt Things that can be improved or refactored

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址