Repository navigation
Fix imports in benchmarks client - #3737
Merged
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes JMH benchmark compilation by correcting imports in the benchmark-only EmptyRedisClusterClient, aligning it with the updated connectToNode signature introduced during the async connect refactor (PR #3735).
Changes:
- Remove the unused
java.util.function.Supplierimport. - Add the missing
reactor.core.publisher.Monoimport required by theconnectToNode(...)parameter type. - Minor formatting (trailing blank line) cleanup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a-TODO-rov
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmarks fail to compile due to issue i introduced in 3735
Note
Low Risk
Test/benchmark-only change limited to imports/signature alignment; no production logic is modified.
Overview
Fixes JMH benchmark compilation by updating
EmptyRedisClusterClientto import ReactorMono(matching theconnectToNodeoverride signature) and removing an unusedSupplierimport.Reviewed by Cursor Bugbot for commit 7fee3a2. Bugbot is set up for automated code reviews on this repo. Configure here.