Skip to content

Some more flakes that were happening tha last few days - #3725

Merged
tishun merged 2 commits into
redis:mainfrom
tishun:topic/tishun/ci-stabilization-timeouts
Apr 24, 2026
Merged

tishun merged 2 commits into
redis:mainfrom
tishun:topic/tishun/ci-stabilization-timeouts

Conversation

@tishun

@tishun tishun commented Apr 20, 2026 •

Copy link
Copy Markdown
Collaborator

These happened during the last few days, both issues are related to timeouts happening in the CI due to the slower infrastructure.

Flaky test RedisClusterPubSubConnectionIntegrationTests#publishToShardChannelViaNewClient

[INFO] Running io.lettuce.core.cluster.pubsub.RedisClusterPubSubConnectionIntegrationTests
Error:  Tests run: 22, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 10.57 s <<< FAILURE! -- in io.lettuce.core.cluster.pubsub.RedisClusterPubSubConnectionIntegrationTests
Error:  io.lettuce.core.cluster.pubsub.RedisClusterPubSubConnectionIntegrationTests.publishToShardChannelViaNewClient -- Time elapsed: 10.02 s <<< ERROR!
java.lang.IllegalStateException: java.util.concurrent.TimeoutException: Objects are not equal: shard msg! and null
	at io.lettuce.test.Wait$Waiter.waitOrTimeout(Wait.java:251)
	at io.lettuce.test.Wait$Waiter.access$900(Wait.java:233)
	at io.lettuce.test.Wait$WaitBuilder.waitOrTimeout(Wait.java:224)
	at io.lettuce.core.cluster.pubsub.RedisClusterPubSubConnectionIntegrationTests.publishToShardChannelViaNewClient(RedisClusterPubSubConnectionIntegrationTests.java:191)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at java.util.ArrayList.forEach(ArrayList.java:1259)
	at java.util.ArrayList.forEach(ArrayList.java:1259)
Caused by: java.util.concurrent.TimeoutException: Objects are not equal: shard msg! and null
	at io.lettuce.test.Wait$Waiter.waitOrTimeout(Wait.java:246)
	... 6 more

Flaky test RedisClusterSetupIntegrationTests#changeTopologyWhileOperations

Error:  Tests run: 18, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 23.74 s <<< FAILURE! -- in io.lettuce.core.cluster.RedisClusterSetupIntegrationTests
Error:  io.lettuce.core.cluster.RedisClusterSetupIntegrationTests.changeTopologyWhileOperations -- Time elapsed: 10.86 s <<< ERROR!
java.lang.IllegalStateException: java.util.concurrent.TimeoutException: Condition not satisfied for: false
	at io.lettuce.test.Wait$Waiter.waitOrTimeout(Wait.java:251)
	at io.lettuce.test.Wait$Waiter.access$900(Wait.java:233)
	at io.lettuce.test.Wait$WaitBuilder.waitOrTimeout(Wait.java:224)
	at io.lettuce.core.cluster.RedisClusterSetupIntegrationTests.changeTopologyWhileOperations(RedisClusterSetupIntegrationTests.java:276)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at java.util.ArrayList.forEach(ArrayList.java:1259)
	at java.util.ArrayList.forEach(ArrayList.java:1259)
Caused by: java.util.concurrent.TimeoutException: Condition not satisfied for: false
	at io.lettuce.test.Wait$Waiter.waitOrTimeout(Wait.java:248)
	... 6 more

Flaky test RedisHandshakeUnitTests#handshakeDelayedCredentialProvider

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Note

Low Risk
Changes are confined to test code, mainly adding JUnit @Tags and loosening/widening waits/timeouts to reduce CI flakes. Low risk aside from potentially masking real timing issues by waiting longer.

Overview
Reduces CI flakes by standardizing JUnit 5 tagging across many test classes using @Tag(TestTags.UNIT_TEST)/@Tag(TestTags.INTEGRATION_TEST) (including static import usage where appropriate).

Adjusts a few timing-sensitive tests to be more tolerant on slow CI: increases Awaitility wait/poll settings in RedisHandshakeUnitTests, adds an explicit during(Duration.ofSeconds(30)) window for a cluster topology wait in RedisClusterSetupIntegrationTests, and ensures shard-channel subscription is observed before publishing in RedisClusterPubSubConnectionIntegrationTests.

Reviewed by Cursor Bugbot for commit fdd1ea6. Bugbot is set up for automated code reviews on this repo. Configure here.

@tishun
tishun requested review from a-TODO-rov and atakavci April 20, 2026 12:49
@tishun tishun added the type: task A general task label Apr 20, 2026
@tishun tishun added this to the Async milestone Apr 20, 2026
…rdChannelViaNewClient flake

Add tags to tests that do not have them
@tishun
tishun merged commit b930ff4 into redis:main Apr 24, 2026
13 checks passed
@tishun
tishun deleted the topic/tishun/ci-stabilization-timeouts branch April 24, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task A general task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址