Repository navigation
Some more flakes that were happening tha last few days - #3725
Merged
tishun merged 2 commits intoApr 24, 2026
Merged
Conversation
…rdChannelViaNewClient flake Add tags to tests that do not have them
a-TODO-rov
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These happened during the last few days, both issues are related to timeouts happening in the CI due to the slower infrastructure.
Flaky test
RedisClusterPubSubConnectionIntegrationTests#publishToShardChannelViaNewClientFlaky test
RedisClusterSetupIntegrationTests#changeTopologyWhileOperationsFlaky test
RedisHandshakeUnitTests#handshakeDelayedCredentialProviderMake sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.Note
Low Risk
Changes are confined to test code, mainly adding JUnit
@Tags and loosening/widening waits/timeouts to reduce CI flakes. Low risk aside from potentially masking real timing issues by waiting longer.Overview
Reduces CI flakes by standardizing JUnit 5 tagging across many test classes using
@Tag(TestTags.UNIT_TEST)/@Tag(TestTags.INTEGRATION_TEST)(including static import usage where appropriate).Adjusts a few timing-sensitive tests to be more tolerant on slow CI: increases Awaitility wait/poll settings in
RedisHandshakeUnitTests, adds an explicitduring(Duration.ofSeconds(30))window for a cluster topology wait inRedisClusterSetupIntegrationTests, and ensures shard-channel subscription is observed before publishing inRedisClusterPubSubConnectionIntegrationTests.Reviewed by Cursor Bugbot for commit fdd1ea6. Bugbot is set up for automated code reviews on this repo. Configure here.