Repository navigation
chore(renovate): keep legacy 4.x System.* packages off the v10 monorepo bumps - #1600
Merged
Merged
Conversation
…po bumps The net4*/netstandard targets pin a set of System.* compatibility packages to their 4.x versions; Renovate's .NET monorepo v10 update (e.g. PR #1598) tries to bump them (such as System.Runtime.Serialization.Formatters 4.3.0 -> 10.0.x in the net4 block), which breaks those targets. Add a packageRule that caps System.* packages currently on 4.x below 5.0.0, leaving the modern 10.x entries free to update.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1600 +/- ##
==========================================
- Coverage 79.40% 78.95% -0.46%
==========================================
Files 116 124 +8
Lines 7168 7036 -132
Branches 1143 1080 -63
==========================================
- Hits 5692 5555 -137
- Misses 1165 1169 +4
- Partials 311 312 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Renovate
packageRulethat capsSystem.*packages currently on the 4.x line below5.0.0.Why
The
net4*/netstandardtargets pin a set ofSystem.*compatibility shims to their 4.x versions insrc/Directory.Packages.props. Renovate's .NET monorepo v10 update (e.g. #1598) tries to bump them — for exampleSystem.Runtime.Serialization.Formatters4.3.0→10.0.xinside the net4 conditional block — which breaks those targets.How
{ "matchManagers": ["nuget"], "matchPackageNames": ["/^System\\./"], "matchCurrentVersion": "/^4\\./", "allowedVersions": "<5.0.0" }matchCurrentVersionscopes the rule to entries already on 4.x, so the modern 10.xSystem.*entries keep updating normally — only the legacy 4.x pins are held under 5.0.0.