Skip to content

chore: update packages, credit Refit's origins, remove stale files - #2336

Merged
glennawatson merged 1 commit into
mainfrom
chore/update-packages-and-cleanup
Sep 25, 2026
Merged

glennawatson merged 1 commit into
mainfrom
chore/update-packages-and-cleanup

Conversation

@glennawatson

Copy link
Copy Markdown
Contributor

Summary

Brings dependencies up to date, gives Refit's original license and inspiration proper credit, and removes root files that no longer do anything.

  • TUnit moves to 1.69.0, ReactiveUI.Primitives to 8.2.0, and the net8.0 Microsoft.AspNetCore.Components.WebAssembly / .DevServer pins to 8.0.31 (the newest release in their framework band).
  • LICENSE now has an attribution section below the ReactiveUI notice. It carries the original 2012 GitHub MIT notice, credits Anna Betts as Refit's creator, and credits Square's Retrofit as the design inspiration. COPYING, which held that notice on its own, is removed. Because LICENSE is packed into every package, the attribution now ships with the NuGet packages too.
  • The devcontainer is removed. It sat in .devcontainers/ (plural), so VS Code and Codespaces never found it. It also targeted .NET 7 and ran a post-create script from a path that does not exist.
  • buildtask.snk (the strong-name key for build tasks that no longer exist), CodeCoverage.runsettings (VSTest-era, still listing xunit and InterfaceStubGenerator.App), the unused stylesheets/ folder, and the unreferenced images/lombiq.svg are removed.

Why

A routine dependency refresh, and it supersedes #2325. COPYING was Refit's original license, which Anna Betts added while Refit was a GitHub project. The MIT License requires keeping that notice, so it now lives in the license file that ships with the packages, not in a separate file nobody reads. The other removed files were left behind by tooling changes over the years, and nothing references them.

Breaking changes

None.

How this was verified

Restored, built and ran the full solution test suite locally. The removed files were checked for references across the repo and solution first.

Notes for the reviewer

The attribution wording in LICENSE is the only part worth reading closely. Everything else is version bumps and deletions.

_config.yml and assets/css/style.scss are kept on purpose: GitHub Pages still builds https://reactiveui.github.io/refit/ from the repo root with the Dinky theme. The docs now live on the website, so retiring Pages and deleting those two files could be a follow-up. codecov.yml is kept because CI still uploads to Codecov.

Checklist

  • I have read the Contribute guide
  • The PR title follows Conventional Commits
  • Tests cover this change, or the summary says why they do not
  • New or changed public API has XML documentation

Bump TUnit to 1.69.0, ReactiveUI.Primitives to 8.2.0 and the net8.0
ASP.NET Components.WebAssembly pins to 8.0.31.

Fold the original 2012 GitHub MIT notice from COPYING into LICENSE under
an attribution section, with credit to Anna Betts and to Square's
Retrofit, and delete COPYING.

Remove the devcontainer (never picked up, .NET 7 era), the unused
buildtask.snk and CodeCoverage.runsettings, the unreferenced legacy
stylesheets folder and the orphaned lombiq sponsor image.
@glennawatson
glennawatson merged commit 2ecbf2a into main Sep 25, 2026
6 of 12 checks passed
@glennawatson
glennawatson deleted the chore/update-packages-and-cleanup branch September 25, 2026 04:36
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址