Repository navigation
chore: update packages, credit Refit's origins, remove stale files - #2336
Merged
Merged
Conversation
Bump TUnit to 1.69.0, ReactiveUI.Primitives to 8.2.0 and the net8.0 ASP.NET Components.WebAssembly pins to 8.0.31. Fold the original 2012 GitHub MIT notice from COPYING into LICENSE under an attribution section, with credit to Anna Betts and to Square's Retrofit, and delete COPYING. Remove the devcontainer (never picked up, .NET 7 era), the unused buildtask.snk and CodeCoverage.runsettings, the unreferenced legacy stylesheets folder and the orphaned lombiq sponsor image.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings dependencies up to date, gives Refit's original license and inspiration proper credit, and removes root files that no longer do anything.
Microsoft.AspNetCore.Components.WebAssembly/.DevServerpins to 8.0.31 (the newest release in their framework band).LICENSEnow has an attribution section below the ReactiveUI notice. It carries the original 2012 GitHub MIT notice, credits Anna Betts as Refit's creator, and credits Square's Retrofit as the design inspiration.COPYING, which held that notice on its own, is removed. BecauseLICENSEis packed into every package, the attribution now ships with the NuGet packages too..devcontainers/(plural), so VS Code and Codespaces never found it. It also targeted .NET 7 and ran a post-create script from a path that does not exist.buildtask.snk(the strong-name key for build tasks that no longer exist),CodeCoverage.runsettings(VSTest-era, still listing xunit andInterfaceStubGenerator.App), the unusedstylesheets/folder, and the unreferencedimages/lombiq.svgare removed.Why
A routine dependency refresh, and it supersedes #2325.
COPYINGwas Refit's original license, which Anna Betts added while Refit was a GitHub project. The MIT License requires keeping that notice, so it now lives in the license file that ships with the packages, not in a separate file nobody reads. The other removed files were left behind by tooling changes over the years, and nothing references them.Breaking changes
None.
How this was verified
Restored, built and ran the full solution test suite locally. The removed files were checked for references across the repo and solution first.
Notes for the reviewer
The attribution wording in
LICENSEis the only part worth reading closely. Everything else is version bumps and deletions._config.ymlandassets/css/style.scssare kept on purpose: GitHub Pages still builds https://reactiveui.github.io/refit/ from the repo root with the Dinky theme. The docs now live on the website, so retiring Pages and deleting those two files could be a follow-up.codecov.ymlis kept because CI still uploads to Codecov.Checklist