[glennawatson]

Summary

Fixes #515
Fixes #665

Both issues have been confirmed as no longer reproducible on the current codebase. This PR adds regression tests to ensure they stay fixed.

#665 - ObjectDisposedException thrown

• Added test: disposing a ValidationHelper with active bindings does not throw
• Added test: disposing a ViewModel with active ErrorsChanged subscriptions does not throw
• Added test: clearing validation rules while IsValid() is subscribed does not throw

#515 - HasErrors incorrect when performing a side effect from WhenAnyPropertyChanged

• Added test: HasErrors reflects correct state inside a WhenAnyValue callback after property changes
• Added test: HasErrors reflects correct state for cross-field validation (MinValue/MaxValue) inside a property change side effect

Test plan

• All 5 new tests pass on net8.0, net9.0, net10.0
• Full test suite (573 tests) passes with no regressions

[Copilot]

Pull request overview

Adds regression coverage to ensure previously fixed issues (#515 HasErrors timing in reactive side-effects, #665 ObjectDisposedException on disposal/clearing with active subscriptions/bindings) remain non-reproducible within the ReactiveUI.Validation test suite.

Changes:

• Added 5 regression tests around disposal safety and HasErrors correctness in reactive callbacks.
• Extended IndeiTestViewModel with MinValue/MaxValue to support cross-field validation regression testing.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
src/tests/ReactiveUI.Validation.Tests/NotifyDataErrorInfoTests.cs	Adds new regression tests for #515 and #665 scenarios (disposal, clearing rules with active subscriptions, HasErrors correctness in reactive callbacks).
src/tests/ReactiveUI.Validation.Tests/Models/IndeiTestViewModel.cs	Adds MinValue/MaxValue properties to support cross-field validation regression tests.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (737b280) to head (7698c26).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #879   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          675       675           
  Branches       113       113           
=========================================
  Hits           675       675           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.