Skip to content

Fix NRE - #657

Merged
ChrisPulman merged 1 commit into
reactiveui:mainfrom
kronic:Fix_NRE
May 10, 2024
Merged

ChrisPulman merged 1 commit into
reactiveui:mainfrom
kronic:Fix_NRE

Conversation

@kronic

@kronic kronic commented May 8, 2024

Copy link
Copy Markdown
Contributor

If you first call the Dispose method on the ReactiveValidationObject, and then call the Dispose ValidationHelper from ValidationRule is happening NRE

@codecov

codecov Bot commented May 8, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.75%. Comparing base (acc39e8) to head (ca95a6f).
Report is 28 commits behind head on main.

Files Patch % Lines
...ation/Extensions/ValidatableViewModelExtensions.cs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #657      +/-   ##
==========================================
- Coverage   71.97%   71.75%   -0.23%     
==========================================
  Files          18       21       +3     
  Lines         703      740      +37     
  Branches      146      153       +7     
==========================================
+ Hits          506      531      +25     
- Misses        119      126       +7     
- Partials       78       83       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisPulman
ChrisPulman merged commit 6bd466f into reactiveui:main May 10, 2024
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址