Repository navigation
Feat: sum benchmarks - #1118
Merged
JakenVeina merged 4 commits intoAug 7, 2026
Merged
Feat: sum benchmarks#1118
Conversation
JakenVeina
requested changes
Jun 24, 2026
| source.AddOrUpdate(replacement, key: id); | ||
| replaceChangeSets.Add(source.CaptureChanges()); | ||
| } | ||
| _replaceChangeSets = replaceChangeSets; |
Collaborator
There was a problem hiding this comment.
You've generated an invalid sequence of changes for all of these, except for _addChangeSets. source.CaptureChanges() also clears out the changes buffer, so when you get around to sending _replaceChangeSets to your operator, what you've got is nothing but Replace changes that refer to items that never had an Add. Apparently, the existing implementation of .Sum() doesn't care, but your new one might.
giard-alexandre
force-pushed
the
feat/sum-benchmarks
branch
from
August 6, 2026 14:53
39e97cb to
dda3906
Compare
JakenVeina
approved these changes
Aug 7, 2026
Contributor
Author
|
That was quick! Thanks @JakenVeina ! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some benchmarks to the Sum aggregate operator.
This is basically a preamble to the full rewrite of the Sum operator, as described in #1031 (comment)