Skip to content

Web tests - #37

Merged
rach merged 2 commits into
rach:developfrom
rlayte:web_tests
Jan 11, 2016
Merged

rach merged 2 commits into
rach:developfrom
rlayte:web_tests

Conversation

@rlayte

@rlayte rlayte commented Jan 10, 2016

Copy link
Copy Markdown
Contributor

Added some basic tests for the web handlers and moved a couple of things around in web.go to make the file structure clearer.

I branched this off develop.

rach added a commit that referenced this pull request Jan 11, 2016
@rach
rach merged commit 437e157 into rach:develop Jan 11, 2016
@rach

rach commented Jan 11, 2016

Copy link
Copy Markdown
Owner

Thanks for tidying and the extra tests.. It makes much more sense.
Do you have any thoughts about #1
I would like to add gzip (#11) support for the api as it's quite a repetitive json which will gzip well. I can do it by hand but maybe it will be good to start using a web library.
I found http://www.gorillatoolkit.org/ quite nice as it's a bit a pick and choose of what you need and it will also reduce the code for context. Let me know if you have any suggestions as I have zero experiences with the differents Go libs for the web.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址