Skip to content

GaugeDelta event Stats() should not send an absolute value of 0. #23

Closed

Description

@mmb

It appears to be copied from the Gauge event, which does not look like the correct logic for GaugeDelta.

Activity

  1. quipo commented on Jan 18, 2016

    @quipo
    Owner

    hey Matthew, should I simply delete this line? https://github.com/quipo/statsd/blob/master/event/gaugedelta.go#L34

  2. mmb commented on Jan 19, 2016

    @mmb
    Author

    Yes I think that's the correct fix.

    If the delta value is negative, it can be sent as is.

    If the delta value is positive it needs to have the '+' added or it will set the value of the gauge instead of applying a delta.

  3. added a commit that references this issue on Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      ⌂ 换网址