Skip to content
This repository was archived by the owner on Sep 28, 2021. It is now read-only.

Get full property tree - #472

Merged
axelssonHakan merged 7 commits into
masterfrom
GetFullPropertyTree
Dec 19, 2019
Merged

axelssonHakan merged 7 commits into
masterfrom
GetFullPropertyTree

Conversation

@axelssonHakan

Copy link
Copy Markdown
Member

No description provided.

@axelssonHakan
axelssonHakan requested a review from glooms December 17, 2019 13:51
Comment thread cmd/object.go
printer.PrintGenericEntityProperties(state, args[0], "object", viper.GetBool("minimum"))
},
}, "minimum")
}, "minimum", "full")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if both minimum and full is set?
Right now it seems like minimum will have precedence.

@wennmo wennmo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, had a minor comment. We should also add a test case for this 👍

Comment thread docs/spec.json Resolved

@glooms glooms left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work Sir! 🎩 ⭐

@wennmo wennmo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@axelssonHakan
axelssonHakan merged commit 161d1be into master Dec 19, 2019
@axelssonHakan
axelssonHakan deleted the GetFullPropertyTree branch December 19, 2019 07:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址