This repository was archived by the owner on Sep 28, 2021. It is now read-only.
Repository navigation
Conversation
wennmo
reviewed
Dec 13, 2019
glooms
marked this pull request as ready for review
December 13, 2019 14:21
wennmo
reviewed
Dec 13, 2019
wennmo
reviewed
Dec 13, 2019
wennmo
reviewed
Dec 13, 2019
wennmo
reviewed
Dec 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We could include a Makefile in our repository.
This is mainly to make testing a bit easier for developers but other things could be included as well.
Since most of our testing is through our integration test there might not be much of an incentive to track coverage since I don't think we can measure it since our tests are run with
os/exec. We have very few unit tests.