Skip to content
This repository was archived by the owner on Sep 28, 2021. It is now read-only.

Add Makefile - #469

Merged
glooms merged 11 commits into
masterfrom
make
Dec 16, 2019
Merged

glooms merged 11 commits into
masterfrom
make

Conversation

@glooms

@glooms glooms commented Dec 12, 2019

Copy link
Copy Markdown
Contributor

We could include a Makefile in our repository.

This is mainly to make testing a bit easier for developers but other things could be included as well.

Since most of our testing is through our integration test there might not be much of an incentive to track coverage since I don't think we can measure it since our tests are run with os/exec. We have very few unit tests.

@glooms
glooms requested a review from wennmo December 12, 2019 15:45
@glooms
glooms requested a review from axelssonHakan December 12, 2019 15:45

@wennmo wennmo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

Comment thread Makefile Resolved
Comment thread Makefile Resolved
Comment thread Makefile Resolved
@glooms
glooms marked this pull request as ready for review December 13, 2019 14:21
Comment thread Makefile Resolved
Comment thread Makefile Resolved
Comment thread Makefile Resolved
Comment thread main.go Resolved

@wennmo wennmo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@glooms
glooms merged commit 36ef6a7 into master Dec 16, 2019
@glooms
glooms deleted the make branch December 16, 2019 12:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址