This repository was archived by the owner on Sep 28, 2021. It is now read-only.
Repository navigation
Enable sense login - #468
Merged
Merged
Conversation
wennmo
reviewed
Dec 10, 2019
glooms
reviewed
Dec 10, 2019
glooms
reviewed
Dec 12, 2019
glooms
reviewed
Dec 12, 2019
| } | ||
|
|
||
| if context == nil { | ||
| log.Fatalf("context '%s' wasn't found.\n", contextName) |
Contributor
There was a problem hiding this comment.
This error message might be confusing in the case where there is no current context. Perhaps check different errors depending on whether there is a contextName or not.
Member
Author
There was a problem hiding this comment.
Great input - thanks
Contributor
|
Wondering how we could test this new functionality without getting into mocks. |
wennmo
reviewed
Dec 13, 2019
Member
|
@glooms Yeah this will be hard to verify in a pipeline unless connecting to a QSEfW instance. In my opinion we should not introduce that kind of external dependency. |
Co-Authored-By: Marcus Lacerda <dxa@qlik.com>
Co-Authored-By: Marcus Lacerda <dxa@qlik.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.