Skip to content
This repository was archived by the owner on Sep 28, 2021. It is now read-only.

Enable sense login - #468

Merged
axelssonHakan merged 20 commits into
masterfrom
enableSenseLogin
Dec 13, 2019
Merged

axelssonHakan merged 20 commits into
masterfrom
enableSenseLogin

Conversation

@axelssonHakan

Copy link
Copy Markdown
Member

No description provided.

@axelssonHakan
axelssonHakan requested a review from glooms December 10, 2019 10:15
Comment thread cmd/context.go Resolved
Comment thread internal/context.go Resolved
Comment thread internal/context.go Resolved
Comment thread internal/context.go Resolved
Comment thread internal/context.go Resolved
Comment thread internal/context.go Resolved
Comment thread internal/context.go Resolved
Comment thread cmd/context.go Resolved

@glooms glooms left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good!
I mostly have some nits.

Comment thread cmd/context.go Resolved
Comment thread internal/context.go Resolved
Comment thread internal/context.go Resolved
Comment thread internal/context.go Resolved
Comment thread internal/context.go Resolved
Comment thread internal/context.go Resolved
Comment thread cmd/context.go Resolved

@glooms glooms left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes! 🌤

Comment thread cmd/flags.go Resolved
Comment thread cmd/flags.go Resolved
Comment thread internal/context.go Outdated
}

if context == nil {
log.Fatalf("context '%s' wasn't found.\n", contextName)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error message might be confusing in the case where there is no current context. Perhaps check different errors depending on whether there is a contextName or not.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great input - thanks

Comment thread internal/context.go Resolved
Comment thread internal/context.go Resolved
@glooms

glooms commented Dec 12, 2019

Copy link
Copy Markdown
Contributor

Wondering how we could test this new functionality without getting into mocks.

Comment thread cmd/context.go Resolved
@wennmo

wennmo commented Dec 13, 2019

Copy link
Copy Markdown
Member

@glooms Yeah this will be hard to verify in a pipeline unless connecting to a QSEfW instance. In my opinion we should not introduce that kind of external dependency.

axelssonHakan and others added 4 commits December 13, 2019 09:21
Co-Authored-By: Marcus Lacerda <dxa@qlik.com>
Co-Authored-By: Marcus Lacerda <dxa@qlik.com>

@wennmo wennmo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@axelssonHakan
axelssonHakan merged commit 521c3db into master Dec 13, 2019
@axelssonHakan
axelssonHakan deleted the enableSenseLogin branch December 13, 2019 13:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址