This repository was archived by the owner on Sep 28, 2021. It is now read-only.
Repository navigation
Allow insecure connections (self signed cert) - #463
Merged
Merged
Conversation
This was referenced Nov 28, 2019
glooms
reviewed
Dec 2, 2019
| log.Verboseln("SessionId " + headers.Get("X-Qlik-Session")) | ||
|
|
||
| var dialer = enigma.Dialer{} | ||
| dialer.TLSClientConfig = tlsClientConfig |
glooms
reviewed
Dec 2, 2019
glooms
approved these changes
Dec 2, 2019
glooms
left a comment
Contributor
There was a problem hiding this comment.
Generally looks good, nice addition. Just wondering why we changed the default web-socket url.
wennmo
reviewed
Dec 3, 2019
wennmo
left a comment
Member
There was a problem hiding this comment.
Looks good, some minor comments
| globalFlags.Bool("bash", false, "Bash flag used to adapt output to bash completion format") | ||
| globalFlags.MarkHidden("bash") | ||
| globalFlags.String("context", "", "Name of the context used when connecting to Qlik Associative Engine") | ||
| globalFlags.BoolP("allow-insecure", "i", false, "Enabling allow-insecure will make it possible to connect using self signed certs") |
Member
There was a problem hiding this comment.
In my opinion we should skip the shorthand flag, since it is not recommended to ignore certificate validation (even if we are using self signed certificates. Also change certs -> certificates
| "clispec": "0.1.0", | ||
| "x-qlik-stability": "stable", | ||
| "flags": { | ||
| "allow-insecure": { |
Member
There was a problem hiding this comment.
Maybe also do a patch bump on the api spec version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename certificates to tlsClientConfig since it will configure both:
The tlsClientConfig will also be created by default now (possible problem?)
The path for connecting to engine is set to "/app/engineData/ttl/" for allowing pass-thru for Qlik Sense Proxy.
An
User-Agentheadercorectl/<version> (<os>)is added to be able to track connections in ingress etc