Skip to content
This repository was archived by the owner on Sep 28, 2021. It is now read-only.

Fatal if failing to set script - #456

Merged
wennmo merged 1 commit into
masterfrom
script-fail
Nov 13, 2019
Merged

wennmo merged 1 commit into
masterfrom
script-fail

Conversation

@wennmo

@wennmo wennmo commented Nov 13, 2019

Copy link
Copy Markdown
Member

If failing to set a script we should log the error and exit, this was not handled earlier.

This closes #455

@glooms glooms left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! ⭐

@wennmo
wennmo merged commit 9307c9f into master Nov 13, 2019
@wennmo
wennmo deleted the script-fail branch November 13, 2019 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No error when corectl fails to set a loadscript

2 participants

⌂ 换网址