Skip to content
This repository was archived by the owner on Sep 28, 2021. It is now read-only.

Run SetProperties in parallel when updating multiple objects - #417

Merged
wennmo merged 4 commits into
masterfrom
set-parallel
Sep 19, 2019
Merged

wennmo merged 4 commits into
masterfrom
set-parallel

Conversation

@wennmo

@wennmo wennmo commented Sep 19, 2019

Copy link
Copy Markdown
Member

When running e.g. the build command creation/updating of objects were done sequentially. This PR changes so it is done in parallel instead. Since we want the output of object ls to be deterministic, I have also changed so the returned objects are sorted in alphabetical order on qId.

This closes #410

Comment thread internal/object.go Resolved
Comment thread internal/object.go Resolved

@axelssonHakan axelssonHakan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️

@glooms glooms left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! So fast! ⚡️

@wennmo
wennmo merged commit 22a9de9 into master Sep 19, 2019
@wennmo
wennmo deleted the set-parallel branch September 19, 2019 12:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SetProperties for commands should be run in parallel

4 participants

⌂ 换网址