Skip to content
This repository was archived by the owner on Sep 28, 2021. It is now read-only.

refactor: Refactor state.go to have one flow for connections - #407

Merged
wennmo merged 5 commits into
masterfrom
refactor-connect
Sep 10, 2019
Merged

wennmo merged 5 commits into
masterfrom
refactor-connect

Conversation

@wennmo

@wennmo wennmo commented Sep 10, 2019 •

Copy link
Copy Markdown
Member

state.go used to have two separate flows for setting up a connection to engine depending if an app were supplied or not. This PR changes so that we only have one flow which will make it easier to maintain and debug.

This closes #340

@wennmo wennmo changed the title Refactor connect Refactor state.go to have one flow for connections Sep 10, 2019

@glooms glooms left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🦑

@wennmo wennmo changed the title Refactor state.go to have one flow for connections refactor: Refactor state.go to have one flow for connections Sep 10, 2019
@wennmo
wennmo merged commit 0fa6d8c into master Sep 10, 2019
@wennmo
wennmo deleted the refactor-connect branch September 10, 2019 13:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactorization of state

2 participants

⌂ 换网址