Skip to content
This repository was archived by the owner on Sep 28, 2021. It is now read-only.

Minor fixes - #397

Merged
glooms merged 10 commits into
masterfrom
minor-fixes
Sep 4, 2019
Merged

glooms merged 10 commits into
masterfrom
minor-fixes

Conversation

@glooms

@glooms glooms commented Sep 4, 2019

Copy link
Copy Markdown
Contributor

Fixed some logging errors.

Fixed some issues with certificates.

  • Certificate paths are now relative to project if they are supplied in a config.
  • context rm now takes multiple parameters and this is reflect in the documentation.

@wennmo wennmo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, otherwise it looks good!

Comment thread cmd/context.go Outdated
Use: "rm <context name>...",
Args: cobra.MinimumNArgs(1),
Short: "Remove one or more contexts",
Long: "Remove one or more context",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Long is shorter than Short! 🙀

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@glooms
glooms merged commit 79d2924 into master Sep 4, 2019
@glooms
glooms deleted the minor-fixes branch September 4, 2019 10:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址