Skip to content
This repository was archived by the owner on Sep 28, 2021. It is now read-only.

Rest refactorization - #341

Merged
glooms merged 7 commits into
masterfrom
rest-refactorization
Jun 27, 2019
Merged

glooms merged 7 commits into
masterfrom
rest-refactorization

Conversation

@glooms

@glooms glooms commented Jun 26, 2019

Copy link
Copy Markdown
Contributor

The rest functionality is now in a separate package under internal.

Also made the URL parsing more robust using the parsing provided by go.

@glooms
glooms requested review from axelssonHakan and wennmo June 26, 2019 15:14

@wennmo wennmo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like the change! Some comments though

Comment thread internal/urlparser.go Resolved
Comment thread cmd/app.go Resolved
Comment thread internal/rest/caller.go Resolved
Comment thread internal/rest/metadata.go Resolved
Comment thread internal/urlparser.go Resolved
Comment thread internal/urlparser_test.go Resolved

@wennmo wennmo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@glooms
glooms merged commit ef155ea into master Jun 27, 2019
@glooms
glooms deleted the rest-refactorization branch June 27, 2019 10:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址