Skip to content
This repository was archived by the owner on Sep 28, 2021. It is now read-only.

File-extension completion for commands - #323

Merged
glooms merged 11 commits into
masterfrom
comp_extensions
Jun 18, 2019
Merged

glooms merged 11 commits into
masterfrom
comp_extensions

Conversation

@glooms

@glooms glooms commented Jun 17, 2019

Copy link
Copy Markdown
Contributor

This PR includes:

  • Updated completion so that commands that take specific file types get suggestions that match, when possible.
  • A way to get completion for PowerShell and added instructions in the README.

@glooms
glooms requested review from gabbaxx and wennmo June 17, 2019 14:14

@wennmo wennmo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just a minor comment regarding the documentation

Comment thread README.md Outdated
```
where `<myalias>` should be substituted for whatever you wish to call `corectl`.

### Windows

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding bash-completion to git bash is still applicable for Windows users as well.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True!

@glooms
glooms merged commit 35b0b8c into master Jun 18, 2019
@glooms
glooms deleted the comp_extensions branch June 18, 2019 10:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址