Skip to content
This repository was archived by the owner on Sep 28, 2021. It is now read-only.

Hide bookmark set - #306

Merged
glooms merged 3 commits into
masterfrom
hide-bookmark-set
Jun 5, 2019
Merged

glooms merged 3 commits into
masterfrom
hide-bookmark-set

Conversation

@glooms

@glooms glooms commented Jun 5, 2019

Copy link
Copy Markdown
Contributor

bookmark set is now hidden because a bookmark cannot be fully created through APIs, meaning that the command might not behave as expected.

Also marked variable and bookmark as experimental as well as changed so that generate-spec works as generate-docs. (You don't have to pipe the output to a file.)

@wennmo wennmo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@glooms
glooms merged commit adb4f9f into master Jun 5, 2019
@glooms
glooms deleted the hide-bookmark-set branch June 5, 2019 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址