Skip to content
This repository was archived by the owner on Sep 28, 2021. It is now read-only.

Add flag for connecting to QSEfW with certificates - #304

Merged
wennmo merged 7 commits into
masterfrom
certs
Jun 3, 2019
Merged

wennmo merged 7 commits into
masterfrom
certs

Conversation

@wennmo

@wennmo wennmo commented Jun 3, 2019

Copy link
Copy Markdown
Member

This PR adds a flag certificates that can be configured to a folder containing root and client certificates. This enables connecting to a QSEfW Engine and bypassing the proxy.

This closes #299

@axelssonHakan axelssonHakan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Maybe mention that it's PEM certificates that we are using

Comment thread docs/corectl_config.md Outdated

### certificates

If you want to connect to a Qlik Sense Enterprise using certificates, it is possible to use the `certificates` parameter. By specifying a path to the folder containing the CA and root certificates, `corectl` will use the certificates when authenticating. `corectl` only supports connecting with `PEM` certificates and expects that `client.pem`, `client_key.pem` and `root.pem` to be present in the configured folder.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"and expects that ... to be" - remove 'that' or "to be" -> "are" :)

@hrigner hrigner left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :)

@wennmo
wennmo merged commit cc58615 into master Jun 3, 2019
@wennmo
wennmo deleted the certs branch June 3, 2019 12:43

@gabbaxx gabbaxx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top notch

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Certificates support for QSEoW Engine

4 participants

⌂ 换网址