Skip to content
This repository was archived by the owner on Sep 28, 2021. It is now read-only.

Added support for bookmarks - #300

Merged
glooms merged 10 commits into
masterfrom
bookmarks
Jun 4, 2019
Merged

glooms merged 10 commits into
masterfrom
bookmarks

Conversation

@glooms

@glooms glooms commented May 31, 2019

Copy link
Copy Markdown
Contributor

This PR contains the addition of commands for managing bookmarks, similar to measures and dimensions.

When testing I encountered some non-deterministic behavior, the cause of which I've not yet discovered.

  • The bookmarks are not always added in order.
  • Title and description of bookmarks are sometimes within the qMeta data and sometimes not.

Closes #297

AddGoldPolisher("(New connection created with id): .*$", "$1: <filtered for gold shininess>")
AddGoldPolisher("localhost:9076", "<host>:<port>")

AddGoldPolisher("(\"qUtcModifyTime\":) .*$", "$1 <filtered for gold shininess>")

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was for golden-tests of bookmarks.

@axelssonHakan axelssonHakan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometime it's generic bookmark and sometimes only ´bookmark`

@wennmo wennmo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good, nice work 👍

Let me know if you want me to take a look at the non-deterministic behaviour that you saw

Comment thread internal/bookmark.go Outdated
return nil
}

// ListBookmarks lists all dimenions in an app

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy paste I guess :)

Comment thread test/corectl_integration_test.go Outdated
p.ExpectOK().Run("bookmark", "ls", "--json")
p.ExpectOK().Run("bookmark", "ls", "--bash")
p.ExpectOK().Run("bookmark", "properties", "alpha-bookmark-1")
// Sometimes title and description is inside qMeta and sometimes outside although created identically.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

@wennmo wennmo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@glooms
glooms marked this pull request as ready for review June 4, 2019 10:58
@glooms
glooms merged commit a754885 into master Jun 4, 2019
@glooms
glooms deleted the bookmarks branch June 4, 2019 11:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add bookmarks

3 participants

⌂ 换网址