This repository was archived by the owner on Sep 28, 2021. It is now read-only.
Repository navigation
Conversation
glooms
commented
May 31, 2019
| AddGoldPolisher("(New connection created with id): .*$", "$1: <filtered for gold shininess>") | ||
| AddGoldPolisher("localhost:9076", "<host>:<port>") | ||
|
|
||
| AddGoldPolisher("(\"qUtcModifyTime\":) .*$", "$1 <filtered for gold shininess>") |
Contributor
Author
There was a problem hiding this comment.
This was for golden-tests of bookmarks.
axelssonHakan
approved these changes
Jun 3, 2019
axelssonHakan
left a comment
Member
There was a problem hiding this comment.
Sometime it's generic bookmark and sometimes only ´bookmark`
wennmo
reviewed
Jun 3, 2019
wennmo
left a comment
Member
There was a problem hiding this comment.
Overall it looks good, nice work 👍
Let me know if you want me to take a look at the non-deterministic behaviour that you saw
| return nil | ||
| } | ||
|
|
||
| // ListBookmarks lists all dimenions in an app |
| p.ExpectOK().Run("bookmark", "ls", "--json") | ||
| p.ExpectOK().Run("bookmark", "ls", "--bash") | ||
| p.ExpectOK().Run("bookmark", "properties", "alpha-bookmark-1") | ||
| // Sometimes title and description is inside qMeta and sometimes outside although created identically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the addition of commands for managing bookmarks, similar to measures and dimensions.
When testing I encountered some non-deterministic behavior, the cause of which I've not yet discovered.
Closes #297