Skip to content
This repository was archived by the owner on Sep 28, 2021. It is now read-only.

Brew/snap readme update - #294

Merged
glooms merged 3 commits into
masterfrom
readme-update
May 28, 2019
Merged

glooms merged 3 commits into
masterfrom
readme-update

Conversation

@glooms

@glooms glooms commented May 28, 2019 •

Copy link
Copy Markdown
Contributor

Added instructions for downloading/installing using snap and brew.

Also added the brew instructions for the version command

Finally closes #246

@wennmo wennmo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor comment. Good job! 🥇

Comment thread cmd/utils.go
fmt.Println("To update to the latest version using brew just run:")
fmt.Print("\n brew upgrade qlik-corectl\n\n")
fmt.Println("If you don't already have the qlik-oss tap you have to add the tap first with:")
fmt.Print("\n brew tap qlik-oss/taps\n\n")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adding the tap you will still need to run brew install qlik-corectl, so that should also be added here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed!

Comment thread cmd/utils.go
fmt.Print("\n brew upgrade qlik-corectl\n\n")
fmt.Println("If you don't already have the qlik-oss tap you have to add the tap first with:")
fmt.Print("\n brew tap qlik-oss/taps\n\n")
fmt.Println("If you prefer curl, you can run:")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... you can run what? :)

@glooms glooms May 28, 2019 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the switch statement, instructions on how to download with curl are printed

@hrigner hrigner left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small comment

@glooms
glooms merged commit 320d5bb into master May 28, 2019
@glooms
glooms deleted the readme-update branch May 28, 2019 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish to brew and snap

4 participants

⌂ 换网址