Skip to content
This repository was archived by the owner on Sep 28, 2021. It is now read-only.

Correctly interpret engine flag in (WSL) bash - #268

Merged
glooms merged 4 commits into
masterfrom
bash-bug
May 7, 2019
Merged

glooms merged 4 commits into
masterfrom
bash-bug

Conversation

@glooms

@glooms glooms commented May 7, 2019

Copy link
Copy Markdown
Contributor

Long explanation:
Apparently, the ${words[@]} argument passed to the __extract_flags_to_forward function splits urls of the form 'host:port/path' into three separate words: 'host', ':' and 'port/path' which leads the bash completion to call corectl list functions with only 'host'. (This gave the illusion of working before since we defaulted to port 9076.)

This PR modifies the __extract_flags_to_forward function to tack on the a colon and port (and path) if present. It also strips trailing white spaces with sed before concatenating.

This closes #255

@glooms
glooms requested review from axelssonHakan and gabbaxx May 7, 2019 07:56
@glooms
glooms merged commit 690c27a into master May 7, 2019
@glooms
glooms deleted the bash-bug branch May 7, 2019 10:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bash completion not working correctly when engine flag is set (WSL)

2 participants

⌂ 换网址