This repository was archived by the owner on Sep 28, 2021. It is now read-only.
Repository navigation
Conversation
axelssonHakan
approved these changes
May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long explanation:
Apparently, the
${words[@]}argument passed to the__extract_flags_to_forwardfunction splits urls of the form 'host:port/path' into three separate words: 'host', ':' and 'port/path' which leads the bash completion to call corectl list functions with only 'host'. (This gave the illusion of working before since we defaulted to port 9076.)This PR modifies the
__extract_flags_to_forwardfunction to tack on the a colon and port (and path) if present. It also strips trailing white spaces withsedbefore concatenating.This closes #255