Skip to content
This repository was archived by the owner on Sep 28, 2021. It is now read-only.

Completion on bash - #184

Merged
wennmo merged 6 commits into
masterfrom
completion_on_bash
Mar 28, 2019
Merged

wennmo merged 6 commits into
masterfrom
completion_on_bash

Conversation

@gabbaxx

@gabbaxx gabbaxx commented Mar 28, 2019

Copy link
Copy Markdown
Contributor

Fixed custom completions in bash
Removed special file completions on windows (default behaviour works ok)

@gabbaxx
gabbaxx requested review from axelssonHakan and wennmo March 28, 2019 12:24
Comment thread cmd/root.go
local flags=$(__extract_flags_to_forward ${words[@]})
local corectl_out=$(corectl get dimensions --bash $flags 2>/dev/null)
__corectl_render_compreply "${corectl_out[*]}"
errorcode=$?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this to a common function for all commands?

Comment thread cmd/root.go

catwalkCmd.PersistentFlags().String("catwalk-url", "https://catwalk.core.qlik.com", "Url to an instance of catwalk, if not provided the qlik one will be used.")

if runtime.GOOS != "windows" {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment to why this is not applicable for windows

@wennmo wennmo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@wennmo
wennmo merged commit 1e33a3c into master Mar 28, 2019
@wennmo
wennmo deleted the completion_on_bash branch March 28, 2019 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址