Skip to content
This repository was archived by the owner on Sep 28, 2021. It is now read-only.

Isolate tests - #131

Merged
axelssonHakan merged 5 commits into
masterfrom
isolateTests
Feb 20, 2019
Merged

axelssonHakan merged 5 commits into
masterfrom
isolateTests

Conversation

@axelssonHakan

Copy link
Copy Markdown
Member

No description provided.

@axelssonHakan
axelssonHakan requested a review from wennmo February 20, 2019 10:17
Comment thread main.go Outdated
}

for _, command := range []*cobra.Command{removeCmd} {
command.PersistentFlags().Bool("suppress", false, "Suppress confirm")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe extend the description a little e.g. Suppress all confirmation dialogues

Comment thread test/corectl_integration_test.go Outdated
teardownTest := setupTest(t, tt)
defer teardownTest(t, tt)

//

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a comment here? 😉

Comment thread test/project1/corectl-alt.yml Resolved
Comment thread main.go Outdated
confirmed = askForConfirmation(fmt.Sprintf("Do you really want to delete the app: %s?", app))
}

if confirmed || viper.GetString("suppress") == "true" {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe its easier if we let askForConfirmation handle the suppress flag? That way we don't need to implement this logic in all methods that would require a confirm dialog later on.

@wennmo wennmo left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work! 🌮

@axelssonHakan
axelssonHakan merged commit b285526 into master Feb 20, 2019
@axelssonHakan
axelssonHakan deleted the isolateTests branch February 20, 2019 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址