This repository was archived by the owner on Sep 28, 2021. It is now read-only.
Repository navigation
Only use the table names from "GetTableAndKeys" - #123
Merged
Merged
Conversation
peol
approved these changes
Feb 8, 2019
peol
left a comment
There was a problem hiding this comment.
LGTM. Perhaps double check with Björn H. that this is the intended behavior?
wennmo
reviewed
Feb 9, 2019
wennmo
left a comment
Member
There was a problem hiding this comment.
Can you also add an integration test for the meta command? This change affects that command and it is currently not covered.
Otherwise it looks good to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #122
Now you get the same tables that you get in Qlik Sense
There seems to be a mismatch between the tables that are included by using
GetTableAndKeysand when using this hypercubeI think the later one returns a few system tables? that I think should not be included (if we want to include them we will have to handle this in another way so corectl does not crash when there is a system table that has no table record)
In the
Sales_Anaylsis.qvfapp it was the tables:_tabToday,Dimensions,Measuresthat was the problem.