Skip to content

增加logfmt parser - #731

Merged
wonderflow merged 2 commits into
qiniu:masterfrom
redHJ:pdr-7241
Aug 28, 2018
Merged

wonderflow merged 2 commits into
qiniu:masterfrom
redHJ:pdr-7241

Conversation

@redHJ

@redHJ redHJ commented Aug 27, 2018

Copy link
Copy Markdown
Collaborator

Comment thread parser/logfmt/logfmt.go
if iValue, err := strconv.ParseInt(value, 10, 64); err == nil {
fields[string(decoder.Key())] = iValue
} else if fValue, err := strconv.ParseFloat(value, 64); err == nil {
fields[string(decoder.Key())] = fValue

@wonderflow wonderflow Aug 28, 2018 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

统一用floatparse,不用Int

@wonderflow

Copy link
Copy Markdown
Contributor

LGTM

@wonderflow
wonderflow merged commit b7385c3 into qiniu:master Aug 28, 2018
@redHJ
redHJ deleted the pdr-7241 branch January 24, 2019 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址