Skip to content

fix mysql - #624

Merged
wonderflow merged 1 commit into
qiniu:masterfrom
wonderflow:fixsql
Jul 21, 2018
Merged

wonderflow merged 1 commit into
qiniu:masterfrom
wonderflow:fixsql

Conversation

@wonderflow

Copy link
Copy Markdown
Contributor

Fixes [issue number]

Changes

  • feature1
  • feature2
  • fixbug1
  • fixbug2

Reviewers

  • @[someone] please review
  • @[someotherone] please review

Wiki Changes

  • options1...
  • options2...

Checklist

  • Rebased/mergeable
  • Tests pass
  • Wiki updated

@redHJ

redHJ commented Jul 21, 2018

Copy link
Copy Markdown
Collaborator

lgtm

Comment thread reader/sql/sql.go
// 每张表的记录数
var tableSize int64
tableSize, err = r.execTableCount(db, idx, curDB, rawSql)
tableSize, err = r.execTableCount(connectStr, idx, curDB, rawSql)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

countdb这边是不是应该也要返回rows.err()?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

并且重试?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个我觉得没有那么重要

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

重试反而重复读数据了

@wonderflow
wonderflow merged commit e257a16 into qiniu:master Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址