Skip to content

fix mssql and postgres connect error - #606

Merged
wonderflow merged 6 commits into
qiniu:masterfrom
xxh2000:master
Jul 16, 2018
Merged

wonderflow merged 6 commits into
qiniu:masterfrom
xxh2000:master

Conversation

@xxh2000

@xxh2000 xxh2000 commented Jul 14, 2018 •

Copy link
Copy Markdown
Contributor

Fixes #605

Changes

  • feature1
  • feature2
  • fixbug1
  • fixbug2

Reviewers

  • @[someone] please review
  • @[someotherone] please review

Wiki Changes

  • options1...
  • options2...

Checklist

  • Rebased/mergeable
  • Tests pass
  • Wiki updated

@xxh2000 xxh2000 changed the title fix mssql connect error fix mssql and postgres connect error Jul 14, 2018
@wonderflow

Copy link
Copy Markdown
Contributor

getConnectStr 可以加个单测吗,防止此类情况再次发生。

感谢!

@redHJ

redHJ commented Jul 15, 2018

Copy link
Copy Markdown
Collaborator

lgtm,谢谢

@wonderflow
wonderflow merged commit 2eff924 into qiniu:master Jul 16, 2018
@xxh2000

xxh2000 commented Jul 16, 2018

Copy link
Copy Markdown
Contributor Author

@wonderflow 是应该加个测试用例验证一下,我有空加个

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

连接sqlserver失败

3 participants

⌂ 换网址