Skip to content

No assertion is thrown when remote SessionDescription doesn't satisfy local #785

New issue
New issue
Closed
Closed
No assertion is thrown when remote SessionDescription doesn't satisfy local#785
Labels
difficulty:moderate

Description

@Sean-Der
Sean-Der
opened on Aug 13, 2019

We need to confirm in what cases things fail/how media section matching is actually supposed to work.

I think we may be missing out on important error handling #784

Activity

  1. Sean-Der
    added
    difficulty:moderate
    triaged
    on Aug 14, 2019
  2. Sean-Der
    added this to the milestone on Jan 23, 2022
  3. Sean-Der
    removed this from the milestone on May 22, 2022
  4. Sean-Der
    removed
    triaged
    on Mar 29, 2024
  5. Sean-Der
    added 10 commits that reference this issue on Sep 28, 2026

    Validate ICE before changing signaling state

    7724059

    Validate fingerprint before changing state

    9166dcd

    Reject duplicate remote SDP media IDs

    4555bc0

    Reject answers with mismatched media counts

    4d08b97

    Reject mismatched answer media types or order

    7c8ca63

    Reject answer media IDs that differ from the offer

    de6fadb

    Reject answers with incompatible media directions

    d0fc244

    Validate ICE before changing signaling state

    8c6c9e9

    Validate fingerprint before changing state

    0b46a74

    Reject duplicate remote SDP media IDs

    510e4a8

  6. 28 remaining items

  7. Sean-Der
    added 13 commits that reference this issue on Sep 28, 2026

    Reject duplicate remote SDP media IDs

    882ef3e

    Reject answers with mismatched media counts

    edc3e48

    Reject mismatched answer media types or order

    b8ca2b2

    Reject answer media IDs that differ from the offer

    19b153f

    Reject answers with incompatible media directions

    79b5808

    Reject answers with incompatible media directions

    cb95b25

    Validate ICE before changing signaling state

    904f87b

    Validate fingerprint before changing state

    01f4719

    Reject duplicate remote SDP media IDs

    3b5d2cc

    Reject answers with mismatched media counts

    11ca1b4

    Reject mismatched answer media types or order

    e720fe9

    Reject answer media IDs that differ from the offer

    945d87b

    Reject answers with incompatible media directions

    983de32

  8. Sean-Der commented on Sep 29, 2026

    @Sean-Der
    Sean-Der
    on Sep 29, 2026
    MemberAuthor

    Resolved by #3577

  9. Sean-Der
    closed this as completedon Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    difficulty:moderate

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions
      ⌂ 换网址