Repository navigation
improve samplebuilder docs #1242
Description
There's no indication of the units for maxLate.
It's not clear what an rtp.Depacketizer is or what a standard one might look like. What is the byte slice arg and what byte slice is it returning? The tests only show a fakeDepacketizer that is a passthrough. In my testing, a passthrough depacketizer works fine. (Should depacketizer by an option? Should it have type func instead of type interface?)
Are Push and Pop safe for concurrent use? If not, what is the intended use? (If you only Pop after Pushing, then it seems like you might lose packets unnecessarily if there is a delay in inbound packets, but maybe I misunderstand.)
Metadata
Metadata
Assignees
Labels
No labels
Activity
tarrencev commentedon Sep 16, 2020
@josharian can we close this with your PR? or are further improvements necessary?
josharian commentedon Sep 17, 2020
I’m no longer using pion; I’m happy to let you decide about the best path forward for this issue.
Sean-Der commentedon Apr 1, 2024
The SampleBuilder has gone through lots of changes since this issue, don't believe these apply anymore.