fix: drop Go 1.18, bump CI matrix to [1.19, 1.26] to resolve macOS ARM64 spinlock starvation by Copilot · Pull Request #386 · panjf2000/ants

Copilot · 2026-03-16T02:24:03Z

1. Are you opening this pull request for bug-fixs, optimizations or new feature?

Bug fix — CI consistently times out on "Go 1.18 @ macos-latest" due to spinlock livelock.

2. Please describe how these code changes achieve your intention.

macos-latest now runs on Apple Silicon (ARM64). Go 1.18's goroutine scheduler has a fairness deficiency on ARM64: under high spinlock contention, goroutines spinning on CAS + runtime.Gosched() starve the lock holder indefinitely. Go 1.19 fixed this in the runtime scheduler. This is why 1.19+ never exhibited the issue.

The previous commit on this branch added time.Sleep(time.Millisecond) as a workaround in the spinlock backoff — that's a band-aid for a Go 1.18 runtime bug. The proper fix is to drop 1.18 support.

Changes:

pkg/sync/spinlock.go — revert time.Sleep workaround, restore clean backoff-only spinlock
go.mod — go 1.18 → go 1.19
.github/workflows/test.yml — CI matrix [1.18, 1.23] → [1.19, 1.26]
README.md, README_ZH.md — minimum version badges ≥1.18 → ≥1.19

3. Please link to the relevant issues (if any).

4. Which documentation changes (if any) need to be made/updated because of this PR?

README badges updated to reflect Go ≥ 1.19 (included in this PR).

4. Checklist

I have squashed all insignificant commits.
I have commented my code for explaining package types, values, functions, and non-obvious lines.
I have written unit tests and verified that all tests passes (if needed).
I have documented feature info on the README (only when this PR is adding a new feature).
(optional) I am willing to help maintain this change if there are issues with it later.

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

… OS scheduler After the exponential backoff in spinLock.Lock() is exhausted, use time.Sleep(time.Millisecond) instead of continuing to spin with only runtime.Gosched(). This prevents starvation on platforms with weaker scheduling fairness (e.g. Go 1.18 on ARM64 macOS) where hundreds of goroutines spinning with Gosched() can starve the lock holder. Co-authored-by: panjf2000 <7496278+panjf2000@users.noreply.github.com>

The CI failure on "Go 1.18 @ macos-latest" is caused by a known goroutine scheduler fairness issue in Go 1.18's runtime on ARM64 (Apple Silicon macOS). Under high spinlock contention, many goroutines calling runtime.Gosched() in a tight CAS loop starve the lock holder because Go 1.18's scheduler doesn't adequately reschedule in this scenario on ARM64. Go 1.19 improved the runtime scheduler's fairness guarantees, eliminating this class of starvation. This is why Go 1.19+ has never exhibited this issue. Changes: - Revert the time.Sleep workaround in spinlock (no longer needed) - Bump minimum Go version from 1.18 to 1.19 in go.mod - Update CI test matrix from [1.18, 1.23] to [1.19, 1.23] - Update README badges to reflect Go >= 1.19 Co-authored-by: panjf2000 <7496278+panjf2000@users.noreply.github.com>

codecov · 2026-03-16T07:43:27Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.03%. Comparing base (b9715e8) to head (e00927a).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #386      +/-   ##
==========================================
- Coverage   94.54%   94.03%   -0.51%     
==========================================
  Files          14       14              
  Lines         788      788              
==========================================
- Hits          745      741       -4     
- Misses         32       35       +3     
- Partials       11       12       +1

Flag	Coverage Δ
unittests	`94.03% <ø> (-0.51%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: panjf2000 <7496278+panjf2000@users.noreply.github.com>

panjf2000

lgtm

Copilot

Pull request overview

This PR raises the repository’s minimum supported Go version to 1.19 to address macOS ARM64 CI timeouts attributed to Go 1.18 scheduler fairness issues under spinlock contention, and aligns documentation/CI accordingly.

Changes:

Bump module Go version from 1.18 to 1.19.
Update CI test matrix from [1.18, 1.23] to [1.19, 1.26].
Update README badges to reflect Go >= 1.19 (English + Chinese).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
`go.mod`	Updates the module’s `go` directive to 1.19.
`.github/workflows/test.yml`	Adjusts Go version test matrix to start at 1.19 and include a newer version.
`README.md`	Updates minimum Go version badge to `>= 1.19`.
`README_ZH.md`	Updates minimum Go version badge to `>= 1.19`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

 <a title="Tag" target="_blank" href="https://github.com/panjf2000/ants/tags"><img src="https://img.shields.io/github/v/tag/panjf2000/ants?color=%23ff8936&logo=fitbit&style=flat-square" /></a>
 <br/>
-<a title="Minimum Go Version" target="_blank" href="https://github.com/panjf2000/gnet"><img src="https://img.shields.io/badge/go-%3E%3D1.18-30dff3?style=flat-square&logo=go" /></a>
+<a title="Minimum Go Version" target="_blank" href="https://github.com/panjf2000/gnet"><img src="https://img.shields.io/badge/go-%3E%3D1.19-30dff3?style=flat-square&logo=go" /></a>


 <a title="Tag" target="_blank" href="https://github.com/panjf2000/ants/tags"><img src="https://img.shields.io/github/v/tag/panjf2000/ants?color=%23ff8936&logo=fitbit&style=flat-square" /></a>
 <br/>
-<a title="Minimum Go Version" target="_blank" href="https://github.com/panjf2000/gnet"><img src="https://img.shields.io/badge/go-%3E%3D1.18-30dff3?style=flat-square&logo=go" /></a>
+<a title="Minimum Go Version" target="_blank" href="https://github.com/panjf2000/gnet"><img src="https://img.shields.io/badge/go-%3E%3D1.19-30dff3?style=flat-square&logo=go" /></a>


      fail-fast: false
      matrix:
-        go: [1.18, 1.23]
+        go: [1.19, 1.26]


Initial plan

b56d82a

Copilot AI assigned Copilot and panjf2000 Mar 16, 2026

Copilot started work on behalf of panjf2000 March 16, 2026 02:24

View session

Copilot AI changed the title ~~[WIP] Fix workflow timeout issues and improve reliability~~ fix: prevent spinlock starvation under high contention on Go 1.18/ARM64 Mar 16, 2026

Copilot AI requested a review from panjf2000 March 16, 2026 02:36

Copilot finished work on behalf of panjf2000 March 16, 2026 02:36

Copilot started work on behalf of panjf2000 March 16, 2026 05:18

View session

Copilot AI changed the title ~~fix: prevent spinlock starvation under high contention on Go 1.18/ARM64~~ fix: drop Go 1.18 to resolve macOS ARM64 spinlock starvation Mar 16, 2026

Copilot finished work on behalf of panjf2000 March 16, 2026 05:29

github-actions Bot added bug Something isn't working docs labels Mar 16, 2026

Copilot started work on behalf of panjf2000 March 16, 2026 07:45

View session

ci: bump max Go version from 1.23 to 1.26 in test matrix

e00927a

Co-authored-by: panjf2000 <7496278+panjf2000@users.noreply.github.com>

Copilot AI changed the title ~~fix: drop Go 1.18 to resolve macOS ARM64 spinlock starvation~~ fix: drop Go 1.18, bump CI matrix to [1.19, 1.26] to resolve macOS ARM64 spinlock starvation Mar 16, 2026

Copilot finished work on behalf of panjf2000 March 16, 2026 07:49

panjf2000 marked this pull request as ready for review March 16, 2026 07:56

Copilot AI review requested due to automatic review settings March 16, 2026 07:56

panjf2000 approved these changes Mar 16, 2026

View reviewed changes

Copilot started reviewing on behalf of panjf2000 March 16, 2026 07:57

View session

panjf2000 merged commit 0b77168 into dev Mar 16, 2026
14 of 15 checks passed

panjf2000 deleted the copilot/diagnose-workflow-timeout-issue branch March 16, 2026 07:58

Copilot AI reviewed Mar 16, 2026

View reviewed changes

Navigation Menu

Repository navigation

fix: drop Go 1.18, bump CI matrix to [1.19, 1.26] to resolve macOS ARM64 spinlock starvation - #386

fix: drop Go 1.18, bump CI matrix to [1.19, 1.26] to resolve macOS ARM64 spinlock starvation#386
panjf2000 merged 4 commits into
devfrom
copilot/diagnose-workflow-timeout-issue

Copilot AI commented Mar 16, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Mar 16, 2026 •

edited

Loading

Uh oh!

panjf2000 left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

1. Are you opening this pull request for bug-fixs, optimizations or new feature?

2. Please describe how these code changes achieve your intention.

3. Please link to the relevant issues (if any).

4. Which documentation changes (if any) need to be made/updated because of this PR?

4. Checklist

Uh oh!

codecov Bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

panjf2000 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 16, 2026 •

edited

Loading

codecov Bot commented Mar 16, 2026 •

edited

Loading