Repository navigation
opt: streamline pool implementation to reduce duplicated code - #350
Merged
Merged
Conversation
github-actions
Bot
added
docs
enhancement
panjf2000
force-pushed
the
pool-refactor
branch
from
January 12, 2025 05:49
5763fad to
7852f9e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #350 +/- ##
==========================================
- Coverage 89.95% 89.71% -0.24%
==========================================
Files 11 11
Lines 1005 797 -208
==========================================
- Hits 904 715 -189
+ Misses 76 62 -14
+ Partials 25 20 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, bump up the minimal required Go version from 1.16 to 1.18.