Repository navigation
bug: return error before creating multi pools if lbs is invalid to avoid leaks - #317
Merged
panjf2000 merged 1 commit intoMar 26, 2024
Merged
Conversation
Owner
|
I think you missed https://github.com/panjf2000/ants/blob/dev/multipool_func.go#L56-L58 |
…valid return err before creating multi pools func if lbs is invalid
akshaynanavare
force-pushed
the
feature/optimize-multipool
branch
from
March 26, 2024 10:24
9ede250 to
7b5ec33
Compare
Contributor
Author
@panjf2000 Yes, Added now. Thanks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #317 +/- ##
=======================================
Coverage 91.30% 91.30%
=======================================
Files 11 11
Lines 759 759
=======================================
Hits 693 693
Misses 45 45
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Are you opening this pull request for bug-fixs, optimizations or new feature?
Yes, for small optimization of multi pools.
2. Please describe how these code changes achieve your intention.
If lbs is invalid then we should immediately return from
NewMultiPoolfunc instead of creating pool arrays and then check for lbs validation3. Please link to the relevant issues (if any).
NA
4. Which documentation changes (if any) need to be made/updated because of this PR?
NA
4. Checklist