Skip to content

opt: fall back to LeastTasks when RoundRobin can't find a worker - #306

Merged
panjf2000 merged 1 commit into
devfrom
multi-pool-opt
Nov 21, 2023
Merged

panjf2000 merged 1 commit into
devfrom
multi-pool-opt

Conversation

@panjf2000

Copy link
Copy Markdown
Owner

No description provided.

Besides, update a few comments and add new benchmarks for multi-pool
@github-actions github-actions Bot added the enhancement New feature or request label Nov 21, 2023
@codecov

codecov Bot commented Nov 21, 2023 •

Copy link
Copy Markdown

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (19bd1ea) 91.28% compared to head (6da5c0a) 90.54%.

Files Patch % Lines
multipool.go 60.00% 4 Missing ⚠️
multipool_func.go 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #306      +/-   ##
==========================================
- Coverage   91.28%   90.54%   -0.74%     
==========================================
  Files          11       11              
  Lines         929      941      +12     
==========================================
+ Hits          848      852       +4     
- Misses         60       68       +8     
  Partials       21       21              
Flag Coverage Δ
unittests 90.54% <60.00%> (-0.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000
panjf2000 merged commit fb82167 into dev Nov 21, 2023
@panjf2000
panjf2000 deleted the multi-pool-opt branch November 21, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request optimization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址