Repository navigation
bug: workerStack's binarySearch - #278
Merged
Merged
Conversation
Avoid overflow when computing mid.
panjf2000
approved these changes
Jun 8, 2023
Owner
There was a problem hiding this comment.
Well, I didn't want to overthink the possibility of this calculation overflowing the int type when we introduced this implemention of binary search, because if that's case, the amount of goroutines in ants would be too significant and it's meaningless to use a goroutine pool like ants. But I guess it's also OK for ants to be finicky here.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #278 +/- ##
==========================================
- Coverage 92.45% 92.44% -0.01%
==========================================
Files 9 9
Lines 769 768 -1
==========================================
- Hits 711 710 -1
Misses 44 44
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid overflow when computing mid.