Skip to content

opt: refactor the worker queue for reusability and readability of code - #270

Merged
panjf2000 merged 1 commit into
masterfrom
refactor-worker
Mar 23, 2023
Merged

panjf2000 merged 1 commit into
masterfrom
refactor-worker

Conversation

@panjf2000

Copy link
Copy Markdown
Owner

No description provided.

@panjf2000 panjf2000 self-assigned this Mar 23, 2023
@github-actions github-actions Bot added the enhancement New feature or request label Mar 23, 2023
@codecov

codecov Bot commented Mar 23, 2023 •

Copy link
Copy Markdown

Codecov Report

Patch coverage: 86.11% and project coverage change: -2.18 ⚠️

Comparison is base (b880b65) 93.20% compared to head (81e825a) 91.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
- Coverage   93.20%   91.03%   -2.18%     
==========================================
  Files           9        9              
  Lines         795      781      -14     
==========================================
- Hits          741      711      -30     
- Misses         41       54      +13     
- Partials       13       16       +3     
Flag Coverage Δ
unittests 91.03% <86.11%> (-2.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
worker.go 93.75% <75.00%> (-6.25%) ⬇️
worker_func.go 93.75% <75.00%> (-6.25%) ⬇️
pool_func.go 87.75% <76.19%> (-4.19%) ⬇️
pool.go 88.84% <93.33%> (-1.74%) ⬇️
worker_loop_queue.go 94.54% <100.00%> (ø)
worker_queue.go 100.00% <100.00%> (ø)
worker_stack.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@panjf2000
panjf2000 merged commit 0313eff into master Mar 23, 2023
@panjf2000
panjf2000 deleted the refactor-worker branch March 23, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址