Improved pull request "Files Changed" experience feedback #163932
Replies: 3321 comments 1384 replies
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
|
i like the old version better |
|
It would be really useful to be able to filter changed files with a filepath glob or similar. I often have PRs that have a very large amount of changes which overwhelm the reviewing UI, but where most of those changes are mechanical changes to test fixtures which I either don't need to review or want to review separately. If I could exclude |
|
Awesome feature guys, well done. The scrolling is broken on the files-changed tab. In a PR with 30 files around 1k lines of changes, from the top of the page touching the scroll wheel instantly jumps to some random location about half way down or further. The location is different every time. If I scroll all the way back to the top and then touch the scroll wheel again to scroll down even a tiny bit, it instantly jumps to a new location. This is on Safari on macOS 27.0.1. |
|
Had an instance today where after making a change to address a comment (inline), rather than the comment no longer appearing in the diff view, and being shown with an "Outdated" label in the overview tab, it was still present in the diff, seemingly attached to the specific line number. |
|
The PR # moveing to the top left corner so tiny is really difficult to see/find |
|
Keyboard shortcuts change: The previous comment box allowed control+enter/command+enter for submit, and the new one only allows alt-enter/option-enter. Pure muscle-memory issue, nothing wrong with alt-enter, but ctrl-enter feels more common to me, so it's going to trip me now and again. |
|
Where is the fils filter? Sometimes i get thousand line prs where there majority of the diff is just translation |



















Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
About the new experience
This updated experience focuses on performance, accessibility, and user productivity. Read more in the changelog.
Tip
If you are not already using the new experience, click the ✨Try the new experience in the upper-right corner of the classic "Files changed" page. You can easily switch back from the Preview menu.
✨ What's new
If you are coming from the classic experience, the new experience should feel familiar but adds some significant improvements:
✨ Updates
See what's been fixed and improved since the launch of the public preview:
🟡 Limitations
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
All reactions