Skip to content

Allow Extractors To Be Registered - #60

Merged
williamfzc merged 1 commit into
opensibyl:masterfrom
cwarden:register-extractor
Feb 25, 2023
Merged

williamfzc merged 1 commit into
opensibyl:masterfrom
cwarden:register-extractor

Conversation

@cwarden

@cwarden cwarden commented Feb 24, 2023

Copy link
Copy Markdown
Contributor

Add extractor.RegisterExtractor function so extractors can register
themselves and be retrieved with extractor.GetExtractor(core.LangType).

Add extractor.RegisterExtractor function so extractors can register
themselves and be retrieved with extractor.GetExtractor(core.LangType).
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #60 (23ac24c) into master (f86f8c5) will decrease coverage by 0.35%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   62.89%   62.55%   -0.35%     
==========================================
  Files          97       97              
  Lines        5479     5490      +11     
==========================================
- Hits         3446     3434      -12     
- Misses       1615     1634      +19     
- Partials      418      422       +4     
Impacted Files Coverage Δ
pkg/extractor/extractor_base.go 33.33% <0.00%> (-28.21%) ⬇️
cmd/sibyl/subs/history/history.go 71.98% <0.00%> (-4.67%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@williamfzc
williamfzc merged commit da8ec54 into opensibyl:master Feb 25, 2023
@williamfzc

Copy link
Copy Markdown
Collaborator

LGTM.
I'd rethink the implementation here.
Sorry for confusing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址