Repository navigation
mutate: allow for custom compression - #348
Merged
Merged
Conversation
cyphar
requested changes
Sep 29, 2020
cyphar
left a comment
cyphar
left a comment
Member
There was a problem hiding this comment.
Seems reasonable, just a few API questions and cleanups that I reckon would be a good idea.
Comment on lines
+17
to
+27
| type withClose struct { | ||
| r io.Reader | ||
| } | ||
|
|
||
| func (wc withClose) Read(p []byte) (n int, err error) { | ||
| return wc.r.Read(p) | ||
| } | ||
|
|
||
| func (wc withClose) Close() error { | ||
| return nil | ||
| } |
Member
There was a problem hiding this comment.
You can switch to ioutil.NopCloser and remove this wrapper.
Member
|
And yeah, I can cook up the CLI UX for it. Oh and I like the new email btw. :P |
Instead of hard coding this media type, allow people to specify it in Add(). This lets us drop AddNonDistributable(), which was just copypasta of Add() with the media type changed. Signed-off-by: Tycho Andersen <tycho@tycho.pizza>
tych0
force-pushed
the
custom-compression
branch
from
September 29, 2020 16:12
a705649 to
5d0bf68
Compare
Member
Author
|
408 while uploading code coverage seems like a transient failure... I re-ran travis. |
at least via the API for now :) Signed-off-by: Tycho Andersen <tycho@tycho.pizza>
tych0
force-pushed
the
custom-compression
branch
from
September 29, 2020 20:22
5d0bf68 to
d82a276
Compare
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
==========================================
+ Coverage 74.45% 74.50% +0.04%
==========================================
Files 57 58 +1
Lines 3054 3051 -3
==========================================
- Hits 2274 2273 -1
+ Misses 455 454 -1
+ Partials 325 324 -1
|
cyphar
reviewed
Sep 29, 2020
|
|
||
| // AddNonDistributable is the same as Add, except it adds a non-distributable | ||
| // layer to the image. | ||
| func (m *Mutator) AddNonDistributable(ctx context.Context, r io.Reader, history *ispec.History) (ispec.Descriptor, error) { |
Member
There was a problem hiding this comment.
Huh, I didn't consider that we could drop AddNonDistributable entirely. Nice. 😸
cyphar
approved these changes
Sep 29, 2020
cyphar
left a comment
cyphar
left a comment
Member
There was a problem hiding this comment.
LGTM. The number of arguments to mutator.Add is getting a bit long but we can always deal with that some other time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
at least via the API for now :)
Signed-off-by: Tycho Andersen tycho@tycho.pizza