Repository navigation
mutate: Add() should tell you what it added - #344
Merged
Merged
Conversation
Right now, there's no way to find out the resulting descriptor that was added to a mutator unless you Commit() it and look up the result. Let's return the descriptor that was added to allow people to reason about it without having to write even more to disk. Signed-off-by: Tycho Andersen <tycho@tycho.ws>
Note that this is a copy, so you can't actually make a change to the original without using the real Add() etc. methods. Signed-off-by: Tycho Andersen <tycho@tycho.ws>
cyphar
reviewed
Jul 20, 2020
Similar to the previous patch where Add() tells you what it added. Signed-off-by: Tycho Andersen <tycho@tycho.ws>
Member
Author
|
Ping? |
Member
|
LGTM, sorry for not looking at this for a while. 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a couple of commits to allow introspection of mutator