Repository navigation
Fix CodeQL build: build with cgo enabled - #1047
Merged
Merged
Conversation
onflow/crypto v0.27.2 and go-ethereum's secp256k1 require cgo, so the CGO_ENABLED=0 build in the CodeQL workflow fails. Remove the outdated no-cgo build instructions from README.md and AGENTS.md.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
vishalchangrani
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CodeQL Analysis workflow fails at the Build step since #1039.
It builds with
CGO_ENABLED=0,but
onflow/cryptov0.27.2 and go-ethereum'ssecp256k1package require cgo:The required
CodeQLcheck reported "neutral",so the failure was not visible.
Changes
code-analysis.yml: build withgo build ./...(cgo enabled, no vendoring).README.md,AGENTS.md: remove the outdated instructionsfor building with
CGO_ENABLED=0and theno-cgotag.Note
GitHub disabled the CodeQL Analysis workflow for inactivity (state
disabled_inactivity),60 days after the last commit on
master.A maintainer must enable it again before the
CodeQLcheck can run on this PR: