Skip to content

Pass invocation context to account balance and storage reads - #4539

Merged
turbolent merged 2 commits into
v1.10from
bastian/v1.10-pass-invocation-context
Nov 9, 2026
Merged

turbolent merged 2 commits into
v1.10from
bastian/v1.10-pass-invocation-context

Conversation

@turbolent

Copy link
Copy Markdown
Member

Description

Pass the invocation context of the running program to the account host functions, so implementations can compute the values with a Cadence function on the same storage as the program, like CreateAccount already does.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent
turbolent enabled auto-merge November 9, 2026 21:15
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

Benchstat comparison

  • Base branch: onflow:v1.10
  • Base commit: 05cfcc2
Results

old.txtnew.txt
time/opdelta
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ByteArrayTransfer-41.76µs ± 0%2.03µs ± 0%~(p=1.000 n=1+1)
ByteArrayValueToByteSlice-488.1ns ± 0%83.8ns ± 0%~(p=1.000 n=1+1)
ByteSliceToByteArrayValue-41.44µs ± 0%1.52µs ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/compiler goos:linux goarch:amd64
CompileFungibleTokenTransferTransaction-4131µs ± 0%131µs ± 0%~(p=1.000 n=1+1)
CompileTime-436.0µs ± 0%36.9µs ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4401µs ± 0%413µs ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ContractImport-4238µs ± 0%236µs ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
EMVAddressTransfer-45.08µs ± 0%5.22µs ± 0%~(p=1.000 n=1+1)
Emit-45.49ms ± 0%5.57ms ± 0%~(p=1.000 n=1+1)
EnumTransfer-41.75µs ± 0%1.72µs ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4268ns ± 0%239ns ± 0%~(p=1.000 n=1+1)
ExportType/simple_type-443.3ns ± 0%44.3ns ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
FTTransfer-4158µs ± 0%159µs ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-424.8µs ± 0%25.3µs ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ImperativeFib-430.8µs ± 0%28.0µs ± 0%~(p=1.000 n=1+1)
ImperativeFibNewCompilerNewVM-455.8µs ± 0%54.2µs ± 0%~(p=1.000 n=1+1)
ImperativeFibNewVM-433.1µs ± 0%31.4µs ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
InterpretRecursionFib-42.36ms ± 0%2.40ms ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
InterpreterFTTransfer-4144µs ± 0%130µs ± 0%~(p=1.000 n=1+1)
InterpreterImperativeFib-426.9µs ± 0%24.6µs ± 0%~(p=1.000 n=1+1)
InterpreterNewStruct-478.3µs ± 0%79.4µs ± 0%~(p=1.000 n=1+1)
MethodCall/concrete_type_method_call-449.6µs ± 0%48.6µs ± 0%~(p=1.000 n=1+1)
MethodCall/interface_method_call-466.0µs ± 0%64.5µs ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
NewInterpreter/new_interpreter-4907ns ± 0%940ns ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-4327ns ± 0%334ns ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
NewResource-4110µs ± 0%110µs ± 0%~(p=1.000 n=1+1)
NewStruct-452.5µs ± 0%52.1µs ± 0%~(p=1.000 n=1+1)
NewStructRaw-44.11µs ± 0%4.09µs ± 0%~(p=1.000 n=1+1)
RecursionFib-41.78ms ± 0%1.68ms ± 0%~(p=1.000 n=1+1)
RuntimeFungibleTokenTransfer-4804µs ± 0%865µs ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4658µs ± 0%667µs ± 0%~(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-42.72ms ± 0%3.04ms ± 0%~(p=1.000 n=1+1)
RuntimeResourceTracking-410.7ms ± 0%11.7ms ± 0%~(p=1.000 n=1+1)
RuntimeScriptNoop-417.2µs ± 0%16.1µs ± 0%~(p=1.000 n=1+1)
RuntimeVMInvokeContractImperativeFib-446.2µs ± 0%48.3µs ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-458.8ns ± 0%59.5ns ± 0%~(p=1.000 n=1+1)
 
alloc/opdelta
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ByteArrayTransfer-41.17kB ± 0%1.25kB ± 0%~(p=1.000 n=1+1)
ByteArrayValueToByteSlice-432.0B ± 0%32.0B ± 0%~(all equal)
ByteSliceToByteArrayValue-4949B ± 0%967B ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/compiler goos:linux goarch:amd64
CompileFungibleTokenTransferTransaction-483.0kB ± 0%83.0kB ± 0%~(all equal)
CompileTime-416.9kB ± 0%16.9kB ± 0%~(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4147kB ± 0%148kB ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ContractImport-479.5kB ± 0%79.4kB ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
EMVAddressTransfer-42.79kB ± 0%2.80kB ± 0%~(p=1.000 n=1+1)
Emit-41.70MB ± 0%1.70MB ± 0%~(p=1.000 n=1+1)
EnumTransfer-4977B ± 0%981B ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4112B ± 0%112B ± 0%~(all equal)
ExportType/simple_type-40.00B 0.00B ~(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
FTTransfer-445.3kB ± 0%45.2kB ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-48.30kB ± 0%8.30kB ± 0%~(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ImperativeFib-46.29kB ± 0%6.29kB ± 0%~(all equal)
ImperativeFibNewCompilerNewVM-426.7kB ± 0%26.7kB ± 0%~(all equal)
ImperativeFibNewVM-49.02kB ± 0%9.02kB ± 0%~(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
InterpretRecursionFib-41.17MB ± 0%1.17MB ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
InterpreterFTTransfer-446.3kB ± 0%46.1kB ± 0%~(p=1.000 n=1+1)
InterpreterImperativeFib-48.29kB ± 0%8.29kB ± 0%~(all equal)
InterpreterNewStruct-426.1kB ± 0%26.1kB ± 0%~(p=1.000 n=1+1)
MethodCall/concrete_type_method_call-411.2kB ± 0%11.2kB ± 0%~(p=1.000 n=1+1)
MethodCall/interface_method_call-418.1kB ± 0%18.1kB ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
NewInterpreter/new_interpreter-41.02kB ± 0%1.02kB ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-4232B ± 0%232B ± 0%~(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
NewResource-445.6kB ± 0%45.6kB ± 0%~(p=1.000 n=1+1)
NewStruct-415.5kB ± 0%15.6kB ± 0%~(p=1.000 n=1+1)
NewStructRaw-41.93kB ± 0%1.93kB ± 0%~(p=1.000 n=1+1)
RecursionFib-4322kB ± 0%322kB ± 0%~(all equal)
RuntimeFungibleTokenTransfer-4251kB ± 0%251kB ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4174kB ± 0%173kB ± 0%~(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-41.81MB ± 0%1.81MB ± 0%~(p=1.000 n=1+1)
RuntimeResourceTracking-47.46MB ± 0%7.42MB ± 0%~(p=1.000 n=1+1)
RuntimeScriptNoop-48.18kB ± 0%8.18kB ± 0%~(p=1.000 n=1+1)
RuntimeVMInvokeContractImperativeFib-415.0kB ± 0%15.0kB ± 0%~(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-432.0B ± 0%32.0B ± 0%~(all equal)
 
allocs/opdelta
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ByteArrayTransfer-48.00 ± 0%8.00 ± 0%~(all equal)
ByteArrayValueToByteSlice-41.00 ± 0%1.00 ± 0%~(all equal)
ByteSliceToByteArrayValue-46.00 ± 0%6.00 ± 0%~(all equal)
pkg:github.com/onflow/cadence/bbq/compiler goos:linux goarch:amd64
CompileFungibleTokenTransferTransaction-4572 ± 0%572 ± 0%~(all equal)
CompileTime-4205 ± 0%205 ± 0%~(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-42.26k ± 0%2.26k ± 0%~(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ContractImport-41.37k ± 0%1.37k ± 0%~(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
EMVAddressTransfer-431.0 ± 0%31.0 ± 0%~(all equal)
Emit-442.0k ± 0%42.0k ± 0%~(all equal)
EnumTransfer-414.0 ± 0%14.0 ± 0%~(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-42.00 ± 0%2.00 ± 0%~(all equal)
ExportType/simple_type-40.00 0.00 ~(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
FTTransfer-41.44k ± 0%1.44k ± 0%~(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4176 ± 0%176 ± 0%~(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ImperativeFib-4321 ± 0%321 ± 0%~(all equal)
ImperativeFibNewCompilerNewVM-4527 ± 0%527 ± 0%~(all equal)
ImperativeFibNewVM-4364 ± 0%364 ± 0%~(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
InterpretRecursionFib-416.5k ± 0%16.5k ± 0%~(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
InterpreterFTTransfer-41.01k ± 0%1.01k ± 0%~(all equal)
InterpreterImperativeFib-4175 ± 0%175 ± 0%~(all equal)
InterpreterNewStruct-4418 ± 0%418 ± 0%~(all equal)
MethodCall/concrete_type_method_call-4392 ± 0%392 ± 0%~(all equal)
MethodCall/interface_method_call-4502 ± 0%502 ± 0%~(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
NewInterpreter/new_interpreter-416.0 ± 0%16.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-44.00 ± 0%4.00 ± 0%~(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
NewResource-4987 ± 0%987 ± 0%~(all equal)
NewStruct-4421 ± 0%421 ± 0%~(all equal)
NewStructRaw-432.0 ± 0%32.0 ± 0%~(all equal)
RecursionFib-418.3k ± 0%18.3k ± 0%~(all equal)
RuntimeFungibleTokenTransfer-44.22k ± 0%4.22k ± 0%~(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-43.22k ± 0%3.22k ± 0%~(all equal)
RuntimeResourceDictionaryValues-436.7k ± 0%36.7k ± 0%~(all equal)
RuntimeResourceTracking-4131k ± 0%131k ± 0%~(p=1.000 n=1+1)
RuntimeScriptNoop-4117 ± 0%117 ± 0%~(all equal)
RuntimeVMInvokeContractImperativeFib-4488 ± 0%488 ± 0%~(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-41.00 ± 0%1.00 ± 0%~(all equal)
 

@turbolent
turbolent disabled auto-merge November 9, 2026 21:27
@turbolent
turbolent merged commit 5f42330 into v1.10 Nov 9, 2026
9 of 15 checks passed
@turbolent
turbolent deleted the bastian/v1.10-pass-invocation-context branch November 9, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址