Skip to content

Assert pretty instructions - #4451

Merged
turbolent merged 1 commit into
masterfrom
bastian/improve-compiler-tests
Mar 11, 2026
Merged

turbolent merged 1 commit into
masterfrom
bastian/improve-compiler-tests

Conversation

@turbolent

Copy link
Copy Markdown
Member

Follow-up to #4423

Description

Refactor new/remaining compiler tests to assert pretty instructions.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions

Copy link
Copy Markdown

Benchstat comparison

  • Base branch: onflow:master
  • Base commit: 3f3470e
Results

old.txtnew.txt
time/opdelta
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ByteArrayValueToByteSlice-475.0ns ± 0%75.3ns ± 0%~(p=1.000 n=1+1)
ByteSliceToByteArrayValue-41.05µs ± 0%1.06µs ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/compiler goos:linux goarch:amd64
CompileFungibleTokenTransferTransaction-4121µs ± 0%124µs ± 0%~(p=1.000 n=1+1)
CompileTime-431.2µs ± 0%31.5µs ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4377µs ± 0%366µs ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ContractImport-4201µs ± 0%198µs ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
Emit-44.77ms ± 0%4.84ms ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4308ns ± 0%314ns ± 0%~(p=1.000 n=1+1)
ExportType/simple_type-466.3ns ± 0%66.1ns ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
FTTransfer-4158µs ± 0%157µs ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-425.1µs ± 0%23.9µs ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ImperativeFib-424.6µs ± 0%24.6µs ± 0%~(p=1.000 n=1+1)
ImperativeFibNewCompilerNewVM-448.7µs ± 0%49.1µs ± 0%~(p=1.000 n=1+1)
ImperativeFibNewVM-426.7µs ± 0%27.1µs ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
InterpretRecursionFib-42.37ms ± 0%2.37ms ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
InterpreterFTTransfer-4127µs ± 0%134µs ± 0%~(p=1.000 n=1+1)
InterpreterImperativeFib-425.4µs ± 0%25.4µs ± 0%~(p=1.000 n=1+1)
InterpreterNewStruct-469.1µs ± 0%68.9µs ± 0%~(p=1.000 n=1+1)
MethodCall/concrete_type_method_call-439.8µs ± 0%39.9µs ± 0%~(p=1.000 n=1+1)
MethodCall/interface_method_call-458.8µs ± 0%59.4µs ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
NewInterpreter/new_interpreter-4868ns ± 0%898ns ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-4341ns ± 0%340ns ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
NewResource-494.2µs ± 0%94.2µs ± 0%~(p=1.000 n=1+1)
NewStruct-443.9µs ± 0%42.3µs ± 0%~(p=1.000 n=1+1)
NewStructRaw-43.93µs ± 0%3.89µs ± 0%~(p=1.000 n=1+1)
RecursionFib-41.33ms ± 0%1.34ms ± 0%~(p=1.000 n=1+1)
RuntimeFungibleTokenTransfer-4772µs ± 0%763µs ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4609µs ± 0%620µs ± 0%~(p=1.000 n=1+1)
RuntimeFungibleTokenTransferVM-4692µs ± 0%695µs ± 0%~(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-42.69ms ± 0%2.71ms ± 0%~(p=1.000 n=1+1)
RuntimeResourceTracking-412.1ms ± 0%11.3ms ± 0%~(p=1.000 n=1+1)
RuntimeScriptNoop-414.2µs ± 0%14.3µs ± 0%~(p=1.000 n=1+1)
RuntimeVMInvokeContractImperativeFib-438.3µs ± 0%39.0µs ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-455.3ns ± 0%56.7ns ± 0%~(p=1.000 n=1+1)
 
alloc/opdelta
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ByteArrayValueToByteSlice-432.0B ± 0%32.0B ± 0%~(all equal)
ByteSliceToByteArrayValue-4868B ± 0%868B ± 0%~(all equal)
pkg:github.com/onflow/cadence/bbq/compiler goos:linux goarch:amd64
CompileFungibleTokenTransferTransaction-482.2kB ± 0%82.2kB ± 0%~(p=1.000 n=1+1)
CompileTime-416.6kB ± 0%16.6kB ± 0%~(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4152kB ± 0%152kB ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ContractImport-479.5kB ± 0%79.4kB ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
Emit-41.50MB ± 0%1.50MB ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4120B ± 0%120B ± 0%~(all equal)
ExportType/simple_type-40.00B 0.00B ~(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
FTTransfer-453.4kB ± 0%53.4kB ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-48.30kB ± 0%8.30kB ± 0%~(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ImperativeFib-45.34kB ± 0%5.34kB ± 0%~(all equal)
ImperativeFibNewCompilerNewVM-425.7kB ± 0%25.7kB ± 0%~(all equal)
ImperativeFibNewVM-48.07kB ± 0%8.07kB ± 0%~(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
InterpretRecursionFib-41.19MB ± 0%1.19MB ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
InterpreterFTTransfer-450.6kB ± 0%50.6kB ± 0%~(p=1.000 n=1+1)
InterpreterImperativeFib-48.29kB ± 0%8.29kB ± 0%~(all equal)
InterpreterNewStruct-424.5kB ± 0%24.6kB ± 0%~(p=1.000 n=1+1)
MethodCall/concrete_type_method_call-410.3kB ± 0%10.3kB ± 0%~(p=1.000 n=1+1)
MethodCall/interface_method_call-417.6kB ± 0%17.6kB ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
NewInterpreter/new_interpreter-4976B ± 0%976B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-4232B ± 0%232B ± 0%~(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
NewResource-443.3kB ± 0%43.3kB ± 0%~(p=1.000 n=1+1)
NewStruct-413.0kB ± 0%13.0kB ± 0%~(p=1.000 n=1+1)
NewStructRaw-42.60kB ± 0%2.60kB ± 0%~(p=1.000 n=1+1)
RecursionFib-4244kB ± 0%244kB ± 0%~(all equal)
RuntimeFungibleTokenTransfer-4246kB ± 0%247kB ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4170kB ± 0%171kB ± 0%~(p=1.000 n=1+1)
RuntimeFungibleTokenTransferVM-4192kB ± 0%192kB ± 0%~(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-41.76MB ± 0%1.76MB ± 0%~(p=1.000 n=1+1)
RuntimeResourceTracking-48.59MB ± 0%8.59MB ± 0%~(p=1.000 n=1+1)
RuntimeScriptNoop-48.04kB ± 0%8.05kB ± 0%~(p=1.000 n=1+1)
RuntimeVMInvokeContractImperativeFib-413.3kB ± 0%13.3kB ± 0%~(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-432.0B ± 0%32.0B ± 0%~(all equal)
 
allocs/opdelta
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ByteArrayValueToByteSlice-41.00 ± 0%1.00 ± 0%~(all equal)
ByteSliceToByteArrayValue-45.00 ± 0%5.00 ± 0%~(all equal)
pkg:github.com/onflow/cadence/bbq/compiler goos:linux goarch:amd64
CompileFungibleTokenTransferTransaction-4563 ± 0%563 ± 0%~(all equal)
CompileTime-4202 ± 0%202 ± 0%~(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-42.47k ± 0%2.47k ± 0%~(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ContractImport-41.30k ± 0%1.30k ± 0%~(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
Emit-440.0k ± 0%40.0k ± 0%~(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-43.00 ± 0%3.00 ± 0%~(all equal)
ExportType/simple_type-40.00 0.00 ~(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
FTTransfer-41.58k ± 0%1.58k ± 0%~(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4176 ± 0%176 ± 0%~(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ImperativeFib-4262 ± 0%262 ± 0%~(all equal)
ImperativeFibNewCompilerNewVM-4470 ± 0%470 ± 0%~(all equal)
ImperativeFibNewVM-4306 ± 0%306 ± 0%~(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
InterpretRecursionFib-417.7k ± 0%17.7k ± 0%~(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
InterpreterFTTransfer-41.11k ± 0%1.11k ± 0%~(all equal)
InterpreterImperativeFib-4175 ± 0%175 ± 0%~(all equal)
InterpreterNewStruct-4418 ± 0%418 ± 0%~(all equal)
MethodCall/concrete_type_method_call-4334 ± 0%334 ± 0%~(all equal)
MethodCall/interface_method_call-4494 ± 0%494 ± 0%~(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
NewInterpreter/new_interpreter-415.0 ± 0%15.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-44.00 ± 0%4.00 ± 0%~(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
NewResource-4919 ± 0%919 ± 0%~(all equal)
NewStruct-4364 ± 0%364 ± 0%~(all equal)
NewStructRaw-438.0 ± 0%38.0 ± 0%~(all equal)
RecursionFib-413.4k ± 0%13.4k ± 0%~(all equal)
RuntimeFungibleTokenTransfer-44.28k ± 0%4.28k ± 0%~(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-43.27k ± 0%3.27k ± 0%~(all equal)
RuntimeFungibleTokenTransferVM-43.73k ± 0%3.73k ± 0%~(all equal)
RuntimeResourceDictionaryValues-436.7k ± 0%36.7k ± 0%~(all equal)
RuntimeResourceTracking-4144k ± 0%144k ± 0%~(all equal)
RuntimeScriptNoop-4114 ± 0%114 ± 0%~(all equal)
RuntimeVMInvokeContractImperativeFib-4424 ± 0%424 ± 0%~(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-41.00 ± 0%1.00 ± 0%~(all equal)
 

@turbolent
turbolent merged commit a637a73 into master Mar 11, 2026
17 checks passed
@turbolent
turbolent deleted the bastian/improve-compiler-tests branch March 11, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址