Repository navigation
Conversation
ocornut
pushed a commit
that referenced
this pull request
Aug 20, 2025
…Info. (#8892) (master branch commit, values are not used)
ocornut
pushed a commit
that referenced
this pull request
Aug 20, 2025
…Info. (#8892) (docking branch commit)
ocornut
added a commit
that referenced
this pull request
Aug 20, 2025
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for viewports in sdl3gpu so that SwapchainParameters in the viewports created can be configured in the same way as the original window. Before my fixes, the windows were initialized without parameters.
SwapchainCompositionandPresentModefields to theImGui_ImplSDLGPU3_InitInfostruct.ImGui_ImplSDLGPU3_CreateWindowto callSDL_SetGPUSwapchainParameterswith the new swapchain configuration values from the initialization struct.Demonstration
To demonstrate the error, the following was used in
examples/example_sdl3_sdlgpu3/main.cppWith different swapchain_composition parameters, sdl3gpu may throw an error without crashing
imgui.no.fix.mp4
After I made changes to
imgui_impl_sdlgpu3.cppandimgui_impl_sdlgpu3.h, two lines were added beforeImGui_ImplSDLGPU3_Initin the fileexamples/example_sdl3_sdlgpu3/main.cppto configure SwapchainParameters in the viewports being createdimgui.fix.mp4